TCollector Collector, prints CPU and RAM usage of collectors #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johann8384
changed the title
The following informations are collected:
- Number of running KVM processes
- CPU and memory statistics per KVM process, the kvm process can be
identified with the following tags:
- pid
- If "-uuid" was passed to the KVM cmdline, the UUID is recorded
as tag
- Number of running tcollector processes
- CPU and memory statistics of tcollector and his hardworking child
processes.
To identify a tcollector process the name of the executable is
recorded in the name tag.
Metrics:
- kvm.cputime
- kvm.mem_bytes
- kvm.processes
- tcollector.cputime
- tcollector.mem_bytes
Kernel < 2.6.24 don't have guest_time and cguest_time values in /proc/%pid/stat. Added a check to make sure that the gatherer doesn't crash on these kernel while trying to read non-existent values.
This was submitted and quickly exploded into "well maybe you should add this" scenario. I stripped it down to only collect tcollector stats and named it appropriately for this narrow scope. There is potential for a general process stat collector in the future. Fixes #66
johann8384
added a commit
that referenced
this pull request
Feb 16, 2016
TCollector Collector, prints CPU and RAM usage of collectors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #66