Python 2.6, 2.7, 3.4, 3.5, 3.6, 3.7 compatibility #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related to issue #218 |
xavierhardy
force-pushed
the
python3
branch
2 times, most recently
from
41eca80 to
18a1d13
Compare
xavierhardy
changed the title
xavierhardy
force-pushed
the
python3
branch
3 times, most recently
from
470ea39 to
16f7a2f
Compare
|
This is great! I did some work on this as well, and did some refactoring to make testing easier. I'll rebase mine to work off this, you went through more collectors than I had gotten to. |
|
Can you add the additional Python version to the Travis build in your branch? Then we can see that is passes with all the versions for your PR. https://github.com/OpenTSDB/tcollector/blob/master/.travis.yml#L3 Thank you !! |
|
Merged in #411 |
|
Thanks for merging and adding the Python 3 environments to Travis. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request brings compatibility from Python 3.4 to Python 3.7 included (
awaitis keyword in 3.7).