Fix memory leak around timestamp precision adjust #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Global MAX_REASONABLE_TIMESTAMP adjusted in error. Due to arbitrary precision arithmetic, over time memory can be seen leaking for lines processed with ms precision timestamps. * Perform timestamp precision check before converting timestamp to int to save allocation of buffer. * Replace space normalization looping construct with split/join.
|
@OpenTSDB Can I get a set of eyes on this? |
|
LGTM, thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Global MAX_REASONABLE_TIMESTAMP adjusted in error. Due to arbitrary precision
arithmetic, over time memory can be seen leaking for lines processed with ms
precision timestamps. Set/adjust local copy max_reasonable_timestamp within scope of function.
Perform timestamp precision check before converting timestamp to int to
save allocation of buffer.
Replace space normalization looping construct with split/join.