New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Read command-line options' defaults from /etc/tcollector.json if present #433

Merged

johann8384 merged 1 commit into OpenTSDB:master from G-Research:itamarst/etc-configuration

Sep 17, 2020

Contributor

itamarst commented Sep 18, 2019

Motivation:

The etc/config.py file is typically installed as something you can't edit. For example, if you're using RPMs, upgrading to next release via RPM will overwrite local changes.
Insofar as you can edit it, you're editing code.

By supporting a configuration file (/etc/tcollector.json) it's easier to have host-specific customization that isn't destroyed by upgrades.


          Read command-line options form /etc/tcollector.json if present.

6302a7a

Contributor Author

itamarst commented Jan 14, 2020

Hey, any chance someone (e.g. @johann8384) could take a look at these and other PRs? Thanks!

johann8384 merged commit 1322657 into OpenTSDB:master

johann8384 added this to the 1.3.3 milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet