Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](style) make the component more adjustable at different appSize #43

Open
wants to merge 8 commits into
base: dev
Choose a base branch
from

Conversation

areski
Copy link
Contributor

@areski areski commented Nov 25, 2020

This PR is making React-SIP-Phone more adjustable with 3 different sizes: small, medium & large.

I tried to keep most of the existing styles byt at the same time offering 2 smaller sizes, it can now nicely shrink down on a div with 150px of width, so that offers the ability to have a much thinner webphone.

image

There is smaller changes on colours choice, hover effect.
You will notice a lot of code for the styling of the react-select, that was unfortunately necessary.

On a second phase it might be nice to get rid of the images icons and import some SVG ones from a library.

@areski
Copy link
Contributor Author

areski commented Dec 21, 2020

@noahmehl Any feedback?

@areski areski closed this Dec 21, 2020
@areski areski reopened this Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant