Deploy contribution tool across different hosts #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ndpnt
force-pushed
the
deploy-contribution-tool-across-different-hosts
branch
from
d93ce1c to
6114dd7
Compare
MattiSG
approved these changes
Nov 18, 2024
src/pages/service.tsx
Outdated
| return JSON.parse( | ||
| JSON.stringify({ | ||
| props: { | ||
| ...props, | ||
| documentTypes: await getDocumentTypes(), | ||
| documentTypes: TERMS_TYPES.default || TERMS_TYPES, |
There was a problem hiding this comment.
Why can't we know exactly how to load the data?
There was a problem hiding this comment.
We know, it was just to make it resilient for futur updates if we change how it is exported as we do not want to maintain this code, but I can simplify it if you prefer?
There was a problem hiding this comment.
Since we have now locked dependencies versions, such a change would need a voluntary update in the codebase so I don't see much point in future-proofing at this stage. Up to you 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also update engine and load terms-types as a dependency