Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Ad Publishing Policy document type #272

Closed
MattiSG opened this issue Jul 14, 2021 · 12 comments
Closed

Remove Ad Publishing Policy document type #272

MattiSG opened this issue Jul 14, 2021 · 12 comments
Labels
RFC Request for comments

Comments

@MattiSG
Copy link
Member

MattiSG commented Jul 14, 2021

I don't believe Ad Publishing Policy is a proper type.

It was added in #264, apparently to support adding Google's Adsense “acceptable use for publishers” (in #262), i.e. this document.

However, the triptych for Ad Publishing Policy is exactly the same as the one for Acceptable Use Policy. These triptychs are exactly there to prevent duplication across similar names.

If the service provider, in the case of Google Adsense as in #264, or Adroll in #269 , is a service whose aim is to provide ads, then the service provider stating in a document how its end users (ad buyers) are expected to have an acceptable and unacceptable usage of the service, is declaring its Acceptable Use Policy.

I thus believe that:

  1. Ad Publishing Policy should be removed as a valid type (or redefined so that its triptych makes clear what is so specific to this new type). All services using them should be updated to Acceptable Use Policy as long as they are ads publishers. A quick search did not make me suspect there would be other services using that document type.
  2. The document declared in Update Google Ads.json #262 should be moved to a new service, Google AdSense. Indeed, Google Ads and Google AdSense are two separate services targeting different users.
  3. Associated documents’ history should be migrated.
  4. Indentation should be fixed in types.json 😉
@clementbiron
Copy link
Member

Ad Publishing Policy should be removed as a valid type (or redefined so that its triptych makes clear what is so specific to this new type). All services using them should be updated to Acceptable Use Policy as long as they are ads publishers. A quick search did not make me suspect there would be other services using that document type.

I agree with that, I can handle it.

The document declared in Update Google Ads.json #262 should be moved to a new service, Google AdSense. Indeed, Google Ads and Google AdSense are two separate services targeting different users.

Idem.

Associated documents’ history should be migrated.

I'm not able to do it. Do you want @MattiSG to take care of it or should I ask @martinratinaud ?

Indentation should be fixed in types.json 😉

Yes ! 👌

@AaronjSugarman being as the origin of the pull request #262, please read this discussion. Your opinion could be important and I would prefer to wait for your answer before going ahead.

Thank you Matti for this feedback

@AaronjSugarman
Copy link
Contributor

AaronjSugarman commented Jul 15, 2021

Ad Publishing Policy should be removed as a valid type (or redefined so that its triptych makes clear what is so specific to this new type). All services using them should be updated to Acceptable Use Policy as long as they are ads publishers. A quick search did not make me suspect there would be other services using that document type.

I agree with that, I can handle it.

The document declared in Update Google Ads.json #262 should be moved to a new service, Google AdSense. Indeed, Google Ads and Google AdSense are two separate services targeting different users.

Idem.

Associated documents’ history should be migrated.

I'm not able to do it. Do you want @MattiSG to take care of it or should I ask @martinratinaud ?

Indentation should be fixed in types.json 😉

Yes ! 👌

@AaronjSugarman being as the origin of the pull request #262, please read this discussion. Your opinion could be important and I would prefer to wait for your answer before going ahead.

Thank you Matti for this feedback

I agree that an "Ad Publisher Policy" is specific type of "Acceptable Use Policy", and thus can be replaced by "Acceptable Use Policy" to simplify things. My only concern and argument in favor of keeping "Ad Publisher Policy" is that it would make it easier to identify which of the Acceptable Use Policies cover ad publishing (i.e. the majority of documents I emailed asking Open Terms Archive to track from GDI). For example, due to my work I'm familiar with which Acceptable Use Policies concern ads by name alone, but I do not believe that to be the case for most audiences. I will ultimately leave it up to your discretion @clementbiron since you know more about the organization of the Open Terms Archive. I hope this feedback was helpful!

@MattiSG
Copy link
Member Author

MattiSG commented Jul 16, 2021

Thank you @AaronjSugarman for your quick reply!

I agree that it would be useful to add some categories to service providers, so that we know that the Acceptable Use Policy for an ad provider is about ads. Right now, that information has to be stored in an independent database outside from OTA.
However, I am not sure we can have a definite ontology for these categories though (i.e. they might not always be exclusive and might be more like tags, or some services might be too hard to classify). Such a system would need a lot more thought.

Do you want @MattiSG to take care of it

No, I'm not familiar enough with that process, sorry 🙁

@clementbiron
Copy link
Member

@martinratinaud could you please migrate the history of documents with the Ad Publishing Policy type to Acceptable Use Policy ?

Full rewrite history documentation is here and there is a detailed explanation for document type renaming.

@martinratinaud
Copy link
Member

Hi @MattiSG

I've tried to rewrite the history but I guess that 1,000,000 commits may be very large to process and will lead to problems.
I will keep trying but with my little knowledge of all this part and the information that it took almost a week to process last time it was done in december, i believe this is not the right way to go for now.

So three options here

  1. leave the document type as is if we consider it not important
  2. get support from @Ndpnt to see if it's possible to bypass this limitation with a hack or a slightly different approach
  3. initiate the big refactoring we've been discussing

I believe 2. could be done to make sure there is definitely not an easy fix but I think we should more focus on getting funded and tackle the whole refactoring alltogether

What do you think ?

@MattiSG
Copy link
Member Author

MattiSG commented Jul 19, 2021

I believe you have a better understanding of the value of the accumulated history for these documents 🙂 I don't believe it is a big problem to leave these commits behind, it is just lost information.

So I would be in support of another option: just migrate all document types, and abandon the history.

@clementbiron
Copy link
Member

I suggest to abandon the history, it seems to me simpler and will allow to start from better bases.

@AaronjSugarma as you are the main person involved in the following of this type of document, does this seem like a feasible option to you ?

@AaronjSugarman
Copy link
Contributor

I suggest to abandon the history, it seems to me simpler and will allow to start from better bases.

@AaronjSugarma as you are the main person involved in the following of this type of document, does this seem like a feasible option to you ?

@clementbiron Would this mean removing all documents that have been classified as an ad publishing policy? I believe that I re-added all the relevant GDI documents through the website link and classified them as Terms Of Service, so that should be fine!

@clementbiron
Copy link
Member

@AaronjSugarman It's mean that the history of the documents with the type Ad Publishing Policy will be loose. In other words, it's like we will start now to follow this documents.

It's better thant ever, what do you think ?

@AaronjSugarman
Copy link
Contributor

@clementbiron I want to point out something Emanuele told me when I showed him this thread:
"Emanuele: Reading through sounds like they be missing the point that there are 2 distinct ad policies
-The "ad policy", regulating the content inside the ad.
-The "publisher content policy" regulating the content around the ad.
All of the "ad publisher policies" submitted are around #2."

@MattiSG
Copy link
Member Author

MattiSG commented Aug 26, 2021

Thanks @AaronjSugarman for this insight!

I think at this stage, we are only talking about replacing the Ad Publishing Policy type with Acceptable Use Policy, for they are duplicates. When documents of the type “Publisher content policy” are added, we can have a discussion around it just like we did in #270 🙂

@MattiSG
Copy link
Member Author

MattiSG commented Jan 17, 2023

Following #984, this issue has been moved to OpenTermsArchive/terms-types#9 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFC Request for comments
Projects
None yet
Development

No branches or pull requests

4 participants