-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Trainline Trackers Policy #814
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for making this contribution. I have reviewed it but I need a bit of clarification from the @OpenTermsArchive/core on a certain number of issues.
First I find the selectors rather complex, but it is understandable given the website is complexly structured. I had alternative selectors here. They are not perfect but I feel less complex than the original ones
{
"name": "Trainline",
"documents": {
"Trackers Policy": {
"fetch": "https://www.thetrainline.com/fr/terms/cookies",
"select": [
".page-template"
],
"remove": [
".root-PjtD4",
".promoBanner-wiaSq a",
".breadcrumb",
".root--MygG"
]
}
}
}
Secondly there are some issues with the generated version. Certain sections are hard to read because of the complex design of the website.
So I am leaving this comment for advise from @OpenTermsArchive/core for how to proceed with this contribution.
Thank you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After careful thought and also going through the documentation on selectors, I find the selectors you had chosen are satisfactory enough for a merge.
However the issue that remains is with regards to the readability of certain sections of the document in the generated version
Thanks @Cli4d for your attention to the resulting version! 👌 |
Sure. I'll then merge this PR and create that issue. Thank you for the clarification on how to handle this situation. |
🔎 Inspect this declaration suggestion
Bots should take care of checking the formatting and the validity of the declaration. As a human reviewer, you should check:
Trainline
matches what you see on the web page, and it complies with the guidelines.Trainline
(i.e. the name of the file) is derived from the service name according to the guidelines.Trackers Policy
is appropriate for this document: if you read out loud the terms type tryptich, you can say that “this document describes how thewriter
commits to handle theobject
for itsaudience
”..tos-content
rather than.ab23 .cK_drop > div
).If no document type seems appropriate for this document yet it is relevant to track in this instance, please check if there is already an open discussion about such a type and reference your case there, or open a new discussion if not.
Thanks to your work and attention, Open Terms Archive will ensure that high quality data is available for all reusers, enabling them to do their part in shifting the balance of power towards end users and regulators instead of spending time collecting and cleaning documents 💪
This suggestion has been created through the Contribution Tool, which enables graphical declaration of documents. You can load it on your local instance if you have one set up.