Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Trainline Trackers Policy #814

Merged
merged 2 commits into from
Nov 20, 2024
Merged

Add Trainline Trackers Policy #814

merged 2 commits into from
Nov 20, 2024

Conversation

OTA-Bot
Copy link
Contributor

@OTA-Bot OTA-Bot commented Sep 13, 2024

🔎 Inspect this declaration suggestion

Bots should take care of checking the formatting and the validity of the declaration. As a human reviewer, you should check:

  • The suggested document matches the scope of this instance: it targets a service in the language, jurisdiction, and industry that are part of those described for this instance.
  • The service name Trainline matches what you see on the web page, and it complies with the guidelines.
  • The service ID Trainline (i.e. the name of the file) is derived from the service name according to the guidelines.
  • The terms type Trackers Policy is appropriate for this document: if you read out loud the terms type tryptich, you can say that “this document describes how the writer commits to handle the object for its audience.
  • Selectors are:
    • stable: as much as possible, the CSS selectors are meaningful and specific (e.g. .tos-content rather than .ab23 .cK_drop > div).
    • simple: the CSS selectors do not have unnecessary specificity (e.g. if there is an ID, do not add a class or a tag).
  • Generated version is:
    • relevant: it is not just a series of links, for example.
    • readable: it is complete and not mangled.
    • clean: it does not contain navigation links, unnecessary images, or extra content.

If no document type seems appropriate for this document yet it is relevant to track in this instance, please check if there is already an open discussion about such a type and reference your case there, or open a new discussion if not.

Thanks to your work and attention, Open Terms Archive will ensure that high quality data is available for all reusers, enabling them to do their part in shifting the balance of power towards end users and regulators instead of spending time collecting and cleaning documents 💪


This suggestion has been created through the Contribution Tool, which enables graphical declaration of documents. You can load it on your local instance if you have one set up.

Copy link
Member

@Cli4d Cli4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making this contribution. I have reviewed it but I need a bit of clarification from the @OpenTermsArchive/core on a certain number of issues.

First I find the selectors rather complex, but it is understandable given the website is complexly structured. I had alternative selectors here. They are not perfect but I feel less complex than the original ones

{
  "name": "Trainline",
  "documents": {
    "Trackers Policy": {
      "fetch": "https://www.thetrainline.com/fr/terms/cookies",
      "select": [
        ".page-template"
      ],
      "remove": [
        ".root-PjtD4",
        ".promoBanner-wiaSq a",
        ".breadcrumb",
        ".root--MygG"
      ]
    }
  }
}

Secondly there are some issues with the generated version. Certain sections are hard to read because of the complex design of the website.

So I am leaving this comment for advise from @OpenTermsArchive/core for how to proceed with this contribution.

Thank you

Copy link
Member

@Cli4d Cli4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After careful thought and also going through the documentation on selectors, I find the selectors you had chosen are satisfactory enough for a merge.

However the issue that remains is with regards to the readability of certain sections of the document in the generated version

chrome_PCinapMBgd

@MattiSG
Copy link
Member

MattiSG commented Nov 18, 2024

Thanks @Cli4d for your attention to the resulting version! 👌
It seems that the table syntax for Markdown is either not properly generated or not properly rendered. Could you please open an issue in the engine repository referencing that one and providing the screenshot, as well as links to the version once it will have been generated? This will enable us to go back to this later 🙂
As it stands, I believe this PR can be merged. One table might not render properly but it is still valuable to track these terms. Thanks!

@Cli4d
Copy link
Member

Cli4d commented Nov 20, 2024

Sure. I'll then merge this PR and create that issue. Thank you for the clarification on how to handle this situation.

@Cli4d Cli4d merged commit 0879777 into main Nov 20, 2024
3 checks passed
@Cli4d Cli4d deleted the add_trainline_trackers_policy branch November 20, 2024 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants