Enable release workflow with branch protection #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
028b46c We would otherwise need to fetch all tags to ensure we don't create an already existing one, which is more costly and less explicit
Prevent validate-changelog workflow from failing on main Avoid unnecessary checks on intermediary branches
MattiSG
commented
Jul 12, 2024
| with: | ||
| token: ${{ secrets.RELEASE_BOT_GITHUB_TOKEN }} | ||
| branch: main | ||
| acceptable_conclusions: 'success,skipped' # changelog checks are skipped when not in a PR towards main branch |
There was a problem hiding this comment.
This will become the default value in the next release, see CasperWA/push-protected#250.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The release workflow implemented in #47 did not take into account the necessary adaptations for
mainbeing a protected branch.This changeset also eliminates duplicate test runs, and stop requiring @OTA-Release-Bot from being admin.
I decided to leave some
test-mainmentions in branch triggers, in order to ease future testing. In this way, creating atest-mainbranch enables testing deployment workflows without editing them. I would understand if this is not welcome and can remove it.