Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linksave handler does not capture complete URL #204

Closed
r00tdaemon opened this issue Jun 1, 2019 · 1 comment
Closed

Linksave handler does not capture complete URL #204

r00tdaemon opened this issue Jun 1, 2019 · 1 comment

Comments

@r00tdaemon
Copy link
Contributor

The regex here does not capture the params in a url.

Possible fix - http://www.noah.org/wiki/RegEx_Python#URL_regex_pattern
r00tdaemon added a commit to r00tdaemon/OTA-Challenge-Bot that referenced this issue Jun 6, 2019
@r00tdaemon
Fixes OpenToAllCTF#204 Change regex to capture complete URL
bab4af2
Kileak added a commit that referenced this issue Jun 6, 2019
@Kileak
Merge pull request #205 from ujjwal96/save-link
14db84e 
Fixes #204 Change regex to capture complete URL
@Kileak
Copy link
Collaborator

Kileak commented Jun 19, 2019

@ujjwal96 was this fixed with your last pr?

@Kileak Kileak closed this as completed Jun 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Kileak @r00tdaemon