Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add backgrounding option to makefile #177

Merged
merged 2 commits into from
Feb 9, 2019

Conversation

crclark96
Copy link
Contributor

solution to #77

open to clarification of use from @Corb3nik, this should provide a way to run the bot in the background, but the grammar can be changed to whatever feels more comfortable

@Corb3nik
Copy link
Collaborator

Corb3nik commented Feb 9, 2019

Seems interesting and way simpler than using tmux/python :D

What do you think @Kileak @Grazfather? I'm not too familiar with Makefiles, but is this the kind of approach we'd like for easy restarting/daemonizing?

@Grazfather
Copy link
Contributor

looks good, but is docker rm necessary? We are running with docker run --rm which should kill the container automatically when we kill it.

@crclark96
Copy link
Contributor Author

guess i overlooked that

fixed

@Grazfather Grazfather merged commit 0adfe2f into OpenToAllCTF:development Feb 9, 2019
@Kileak
Copy link
Collaborator

Kileak commented Feb 11, 2019

What happens to the console and the debug log in "background mode"?

I like the tmux approach pretty much, because it makes it easy to see what's currently happening in the bot and also have the error messages at hand, if something goes bad.

@crclark96
Copy link
Contributor Author

docker logs otabot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants