-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#445 Add popup in Calendar to enable the show more via popup feature in month view #451
Conversation
I see this PR is still in draft status, but it's a simple enough change that I think it can be reviewed now. Everything builds just fine on my machine. I merged in my latest changes from main (so you have one less task for you to do). Yarn didn't need to delint anything. Two behaviors I observed that we can chat about in our meeting this morning:
If neither of these are addressable/configurable, that's totally fine, and I approve of this PR as it stands now. |
Popup doesn't move with the day in the calendar
I think for now it seems like there is no quick fix for this. |
"+[x] more" link would only show the missing items
|
@wendyyng Awesome, thanks for doing that research! Then I agree, this is ready to go. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes appear as expected on my local machine, and I'm in agreement with Wendy re: having the popup include all activities!
Proposed changes
This PR resolves the #445 by enabling the
react-big-calendar
to show a popup with all the activities of the selected date when the user clicks '+ more' in the calendar's month view. The activities in the popup are also clickable and show the activity dialog with activity information when clicked.Checklist