Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed user authentication details in mobile navbar #83

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

sachintom999
Copy link
Contributor

@sachintom999 sachintom999 commented Oct 17, 2023

Whether the user has logged in or not, the mobile navbar always shows the "Sign In" and "Sign Up" .

The commit fixes this.

It shows the details correctly if the user has logged in or not.

Attaching the "before" and "after" screenshots

Before Fix

before-fix

After Fix

after-fix

@dogukanteber
Copy link
Collaborator

dogukanteber commented Oct 17, 2023

Hi, @sachintom999. Thank you for your contribution. It is a crucial and important fix. Also, thank you for the illustration 🎸

@dogukanteber dogukanteber merged commit aeb9614 into OpenUnited:main Oct 17, 2023
@adrianmcphee
Copy link
Contributor

Super work @sachintom999

@sachintom999 sachintom999 deleted the fix-mobile-navbar-auth branch October 18, 2023 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants