Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort variables fk in profile indicator admin #182 #185

Merged
merged 1 commit into from
Jan 11, 2021

Conversation

goyal1092
Copy link
Collaborator

Description

Sorted Variables FK to sort by specific text Dataset name -> Variable name

Related Issue

#182

How to test it locally

Go to profile indicator admin page and checkout the variables drop down
Data should be sorted according to key Dataset name -> Variable name

Changelog

Added formfield_for_foreignkey method in profile indicator admin file

Added

Updated

Removed

Checklist

  • 🚀 is the code ready to be merged and go live?
  • 🛠 does it work (build) locally

Pull Request

  • 📰 good title
  • 📝good description
  • 🔖 issue linked
  • 📖 changelog filled out

Commits

  • commits are clean
  • commit messages are clean

Code Quality

  • 🚧 no commented out code
  • 🖨 no unnecessary logging
  • 🎱 no magic numbers
  • black was run locally (as part of the pre-commit hook)

Testing

  • ✅ added (appropriate) unit tests
  • 💢 edge cases in tests were considered
  • ✅ ran tests locally & are passing

@goyal1092 goyal1092 linked an issue Dec 8, 2020 that may be closed by this pull request
@milafrerichs milafrerichs merged commit b4cdda3 into OpenUpSA:staging Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve variable selection when creating a profile indicator
2 participants