Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Track down username access casing #180

Closed
Martii opened this issue Jun 18, 2014 · 3 comments
Closed

Track down username access casing #180

Martii opened this issue Jun 18, 2014 · 3 comments
Labels
DB Pertains inclusively to the Database operations. duplicate This means already been reported. Always reference in a comment what issue or pull request number…

Comments

@Martii
Copy link
Member

Martii commented Jun 18, 2014

This user has scripts with lower case username (here for example)... but can only access the user page with the properly cased username. Same goes with my account too... I assume most others that have capitals in them as well.

Mentioned briefly in this comment from #130 and probably applies to #135
@Martii Martii added the bug label Jun 18, 2014
@sizzlemctwizzle
Copy link
Member

This is basically a duplicate of #130. I already know that usernames in script paths are lowercase and case sensitive on the user page. I intend to fix this with #130.

@Martii
Copy link
Member Author

Martii commented Jun 18, 2014

Alright was just wondering if there was a workaround in the meantime... putting sooner label on #130 because it would be nice to identify authors without having to go through the user list and before ppl start utilizing exact urls more. Marking as duplicate but will keep open if you think there is a temporary workaround... otherwise close please.

P.S. Wish there was a "freeze" issues flag on GH kind of like the lock issue so big things like these could temporarily halt all others. #130 and #135 should probably be near our first priority as of now. I've been dancing around those quite a bit in testing with figuring out what to do next and/or simultaneously.

@Martii
Copy link
Member Author

Martii commented Jun 22, 2014

Closed by #130

@Martii Martii closed this as completed Jun 22, 2014
@Martii Martii added the DB label Jul 3, 2014
@Martii Martii removed the bug label Jul 20, 2014
Martii referenced this issue Jul 6, 2015
@sizzlemctwizzle
Finished code changes for migration.
5b65abd
Martii pushed a commit to Martii/OpenUserJS.org that referenced this issue Jul 7, 2015
Hot fix for OpenUserJS#656
372c885 
* **NOTE** This is not the permanent solution but a compromise on existing S3 DB structure and this hot fix isn't as effecient as OpenUserJS#486 solution *(hence the term hot fix vs solution)*.
* Change `caseInsensitive` regular expression maker into `caseSensitive` with exception on username to accomodate OpenUserJS#180 without the issue in OpenUserJS#656
* This removes the future security issue with unintended hidden scripts... manual DB examination will need to happen for anyone who has done this before but can be done in time with @sizzlemctwizzle and/or @Martii... future scripts should properly be created at least.
* Noted code inconsistency with `installName` versus "more than `installName`"... this should be corrected at some point.
* Leaving `caseInsensitive` in as a potential library function in `scriptStorage`... which could probably be in libs but that's where it is currently.

Closes OpenUserJS#656
@Martii Martii mentioned this issue Jul 7, 2015
Merged
Martii pushed a commit to Martii/OpenUserJS.org that referenced this issue Jul 7, 2015
Missed STYLEGUIDE.md conformance
02fccb1 
* Still used to a slightly different coding style myself...apologies

Applies to OpenUserJS#658, OpenUserJS#656, OpenUserJS#486, and OpenUserJS#180
@Martii Martii mentioned this issue Jul 7, 2015
Merged
Martii pushed a commit to Martii/OpenUserJS.org that referenced this issue Apr 15, 2017
Ensure session username is same casing
ef93bfd 
* This goes back to when I first came into the project and noticed that `marti` and `Marti` were inconsistent in script access
* Added in a WARNING note for no error handling again

Applies to OpenUserJS#83 and OpenUserJS#180 / OpenUserJS#130 / OpenUserJS#130 (comment)
@Martii Martii mentioned this issue Apr 15, 2017
Merged
Martii added a commit that referenced this issue Apr 15, 2017
@Martii
Ensure session username is same casing (#1083)
55e2f4c 
* This goes back to when I first came into the project and noticed that `marti` and `Marti` were inconsistent in script access
* Added in a WARNING note for no error handling again

Auto-merge

Applies to #83 and #180 / #130 / #130 (comment)
Martii pushed a commit to Martii/OpenUserJS.org that referenced this issue Apr 20, 2017
Ensure casing on username is identical for S3 retrieval from DB
4d744d6 
Applies to OpenUserJS#486 / OpenUserJS#180 / OpenUserJS#130 / OpenUserJS#130 (comment) / OpenUserJS#819
@Martii Martii mentioned this issue Apr 20, 2017
Merged
Martii added a commit that referenced this issue Apr 20, 2017
@Martii
Ensure casing on username is identical for S3 retrieval from DB (#1086)
583c4a5 
Applies to #486 / #180 / #130 / #130 (comment) / #819 

Auto-merge
@OpenUserJS OpenUserJS locked as resolved and limited conversation to collaborators Apr 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
DB Pertains inclusively to the Database operations. duplicate This means already been reported. Always reference in a comment what issue or pull request number…
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sizzlemctwizzle @Martii