Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Libraries don't appear to sync #723

Closed
Martii opened this issue Aug 29, 2015 · 2 comments · Fixed by #1260
Closed

Libraries don't appear to sync #723

Martii opened this issue Aug 29, 2015 · 2 comments · Fixed by #1260
Labels
bug You've guessed it... this means a bug is reported.

Comments

@Martii
Copy link
Member

Martii commented Aug 29, 2015

Apparently this seems to go way back in the initial commit... (pre me being here) ... and propagated ever since through refactors of GH importing.

Option 1: Sync any *.js and *.user.js

Option 2: Modify the sync script column at https://openuserjs.org/user/add/lib ... to reflect what we don't do.

Option number one is preferred imo.

Historical issue(s):
@Martii Martii added the bug You've guessed it... this means a bug is reported. label Aug 29, 2015
@Martii Martii mentioned this issue Aug 29, 2015
Merged
@Martii Martii added the needs discussion Blah, blah, blah, wahh, wahh, wahh, etc. label Aug 29, 2015
@Martii
Copy link
Member Author

Martii commented Aug 30, 2015

We could use the OpenUserJS metadata block and a new key to detect these btw... just a misc. thought. Will need to parse the full compliment of parsers though (which is relatively easy as I started out doing that) as I only parsed the UserScript metadata block in #724

@sizzlemctwizzle
Copy link
Member

I really like that idea. It gives us a way to get the name, version, and
license from the library source.
On Aug 30, 2015 5:03 AM, "Marti Martz" notifications@github.com wrote:

We could use the OpenUserJS metadata block and a new key to detect these
btw... just a misc. thought. Will need to parse the full compliment of
parsers though (which is relatively easy as I started out doing that)
as I only parsed the UserScript metadata block in #724
#724

—
Reply to this email directly or view it on GitHub
#723 (comment)
.

@Martii Martii mentioned this issue Oct 7, 2015
Closed
@Martii Martii mentioned this issue Dec 30, 2015
Merged
Martii pushed a commit to Martii/OpenUserJS.org that referenced this issue Feb 5, 2016
Some visual notices for script minification issues
ae222ec 
* Fix a regular expression to use environment port if available ... this is a dev bug
* Some prior typos and comments clarified
* New OpenUserJS metadata block key of `unstableMinify`... following Scriptish example of camel casing *(interCaps)*. This requires a string after it which is the reason why... invalid reasons may reduce ones karma :)
* Using boolean switch so that the view contains the strings and not the controller/libs side of our code... useful for OpenUserJS#18 and how views should eventually be rendered
* Libraries aren't covered yet because of OpenUserJS#723
* `decodeURIComponent` is required as per OpenUserJS#819 ... do a trap for now just in case it fails... which may produce a false positive but these are just notices at this time

Applies to OpenUserJS#432
@Martii Martii mentioned this issue Feb 5, 2016
Merged
@Mottie Mottie mentioned this issue May 16, 2017
Closed
@Martii Martii mentioned this issue Jul 20, 2017
Closed
Martii added a commit to Martii/OpenUserJS.org that referenced this issue Nov 17, 2017
@Martii
Sync libs too
5858bc4 
* This could probably be shortened/optimized but did work on a test I started yesterday and redelivered from GH today.

Closes OpenUserJS#723
@Martii Martii mentioned this issue Nov 17, 2017
Merged
Martii added a commit that referenced this issue Nov 17, 2017
@Martii
Sync libs too (#1260)
013407a 
* This could probably be shortened/optimized but did work on a test I started yesterday and redelivered from GH today.

Closes #723

Auto-merge
@Martii Martii removed the needs discussion Blah, blah, blah, wahh, wahh, wahh, etc. label Dec 22, 2017
@OpenUserJS OpenUserJS locked as resolved and limited conversation to collaborators Apr 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug You've guessed it... this means a bug is reported.
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Sync libs too Martii/OpenUserJS.org
2 participants
@sizzlemctwizzle @Martii