Do some validation on @downloadURL for OUJS based URIs
#1004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Additional validation on `@name` * Fix trimming in lib model meta `name`... **NOTE** `trim()` is technically ES5.1 and is used elsewhere already... so normalizing on that Post fix for OpenUserJS#944 and applies to OpenUserJS#432 and OpenUserJS#819... also from initial library creation
Martii
added
bug
Martii
added a commit
that referenced
this pull request
May 7, 2016
Post #1004 fix on null * Server trip fix
Martii
pushed a commit
to Martii/OpenUserJS.org
that referenced
this pull request
May 29, 2016
* Fix someone who did an OUJS script homepage for a `downloadURL`... should cover any other non-Userscript-source route. Previous meta check is inclusive since that's not a Userscript source route. Post fix for OpenUserJS#944 and OpenUserJS#1004 change
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@namename... NOTEtrim()is technically ES5.1 and is used elsewhere already... so normalizing on thatPost fix for #944 and applies to #432 and #819... also from initial library creation