Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invert remote saves #1098

Merged
merged 1 commit into from
May 1, 2017
Merged

Invert remote saves #1098

merged 1 commit into from
May 1, 2017

Conversation

Martii
Copy link
Member

@Martii Martii commented May 1, 2017

  • On rare occasions S3 connection goes down so improve error logging... UI will currently show 404 on script edit submit... ideally this should be 502 but will work as former. UI new scripts will bail out and reload empty editor.
  • MongoDB, once inside .save it will not abort unless it's a .pre option with the schema which we don't currently utilize due to code structure so do it last.
  • Improve logging for MongoDB errors... if MongoDB connection goes down script source will be saved but UI will be out of sync instead of completely absent on a request... these are even rarer than S3.
  • Denoted fallthrough comment on an error trap if User elevation didn't happen but log for Admin+ intervention.

NOTES:
unmarkModified is pretty much useless in this case scenario but was tested

Applies to #430 / #72 Related to #486

Invert remote saves
9f4a8ca 
* On rare occasions S3 connection goes down so improve error logging... UI will currently show 404 on script edit submit... ideally this should be 502 but will work as former. UI new scripts will bail out and reload empty editor.
* MongoDB, once inside `.save` it will **not** abort unless it's a `.pre` option with the schema which we don't currently utilize due to code structure so do it last.
* Improve logging for MongoDB errors... if MongoDB connection goes down script source will be saved but UI will be out of sync instead of completely absent on a request... these are even rarer than S3.
* Denoted `fallthrough` comment on an error trap if User elevation didn't happen but log for Admin+ intervention.

NOTES:
`unmarkModified` is pretty much useless in this case scenario but was tested

Applies to OpenUserJS#430 / OpenUserJS#72 Related to OpenUserJS#486
@Martii Martii added bug You've guessed it... this means a bug is reported. CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. enhancement Something we do have implemented already but needs improvement upon to the best of knowledge. labels May 1, 2017
@Martii Martii merged commit 1424dce into OpenUserJS:master May 1, 2017
@Martii Martii deleted the invertRemoteSaves branch May 1, 2017 18:33
@Martii Martii mentioned this pull request May 7, 2017
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
bug You've guessed it... this means a bug is reported. CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. enhancement Something we do have implemented already but needs improvement upon to the best of knowledge.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Martii