-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set maxAge
idle session to four (4) hours
#1202
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* This can be tweaked to slightly larger but the default of two weeks server side is too much. Sync both client access and server expiration to this value. * Going to bump all stored sessions in a few moments Related to OpenUserJS#604
Martii
added
CODE
Some other Code related issue and it should clearly describe what it is affecting in a comment.
enhancement
Something we do have implemented already but needs improvement upon to the best of knowledge.
security
Usually relates to something critical.
DB
Pertains inclusively to the Database operations.
labels
Oct 26, 2017
Martii
added a commit
to Martii/OpenUserJS.org
that referenced
this pull request
Nov 9, 2017
* Alternative is "Remember me" option although I think I'd rather have a "Forget me" option by default. Post OpenUserJS#1202 and related to OpenUserJS#604
Martii
added a commit
that referenced
this pull request
Nov 9, 2017
Martii
added a commit
to Martii/OpenUserJS.org
that referenced
this pull request
Nov 9, 2017
* Alternative is "Remember me" option although I think I'd rather have a "Forget me" option by default. Post OpenUserJS#1202 and related to OpenUserJS#604
Martii
added a commit
that referenced
this pull request
Nov 9, 2017
Martii
added a commit
to Martii/OpenUserJS.org
that referenced
this pull request
Nov 14, 2017
* Move to six as per sizzle Post OpenUserJS#1202 and related to OpenUserJS#604
Merged
Martii
added a commit
that referenced
this pull request
Nov 14, 2017
Martii
added a commit
to Martii/OpenUserJS.org
that referenced
this pull request
May 31, 2018
* Alternative is "Remember me" option although I think I'd rather have a "Forget me" option by default. Post OpenUserJS#1202 and related to OpenUserJS#604
Martii
added a commit
to Martii/OpenUserJS.org
that referenced
this pull request
Jun 12, 2018
* Use very short session before successful auth. Session "bleeding" briefly mentioned at OpenUserJS#1411 . This is "expanded" after successful auth. * Output `originalMaxAge` for sync check in *express-session* via MongoDB * Don't easily expose improper/expired callbacks. Part of OpenUserJS#37 * Remove some currently unneeded `return` statements already captured by block braces Related to OpenUserJS#604 OpenUserJS#1201 OpenUserJS#1202 and OpenUserJS#1393
Merged
Martii
added a commit
that referenced
this pull request
Jun 12, 2018
* Use very short session before successful auth. Session "bleeding" briefly mentioned at #1411 . This is "expanded" after successful auth. * Output `originalMaxAge` for sync check in *express-session* via MongoDB * Don't easily expose improper/expired callbacks. Part of #37 * Remove some currently unneeded `return` statements already captured by block braces Related to #604 #1201 #1202 and #1393 Auto-merge
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
CODE
Some other Code related issue and it should clearly describe what it is affecting in a comment.
DB
Pertains inclusively to the Database operations.
enhancement
Something we do have implemented already but needs improvement upon to the best of knowledge.
security
Usually relates to something critical.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #604