Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert to TTL #1473

Merged
merged 1 commit into from
Jun 30, 2018
Merged

Revert to TTL #1473

merged 1 commit into from
Jun 30, 2018

Conversation

Martii
Copy link
Member

@Martii Martii commented Jun 30, 2018

  • The cost of interval mode is too high plus it also has a similar, yet muffled, issue as native. Each session gets it's own server side (OUJS) timer and that can be really CPU intensive if too many users pop on board at the same time.
  • MongoDB remote is not cleaning up expired sessions until many, many, many hours later... this may subside at a later date but something we need to live with at the moment until the main DB is migrated to a newer version (probably one minor semver at a time). *hint hint* @sizzlemctwizzle
  • Reoutput the originalMaxAge as a label.
  • New dep extension (plugin as they call it) that extends moment
  • Max extension age is n (currently 6) times 3... may change these values after some more consultation

Post #1471 ... related to #604

@Martii
Revert to TTL
cd01d0b 
* The cost of `interval` mode is too high plus it also has a similar, yet muffled, issue as `native`. Each session gets it's own server side *(OUJS)* timer and that can be really CPU intensive if too many users pop on board at the same time.
* MongoDB remote is not cleaning up expired sessions until many, many, many hours later... this may subside at a later date but something we need to live with at the moment until the main DB is migrated to a newer version *(probably one minor semver at a time)*. \*hint hint\* @sizzlemctwizzle
* Reoutput the `originalMaxAge` as a label.
* New dep extension *(plugin as they call it)* that extends *moment*
* Max extension age is n *(currently 6)* times 3... may change these values after some more consultation

Post OpenUserJS#1471 ... related to OpenUserJS#604
@Martii Martii added enhancement Something we do have implemented already but needs improvement upon to the best of knowledge. UI Pertains inclusively to the User Interface. DB Pertains inclusively to the Database operations. CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. labels Jun 30, 2018
@Martii Martii merged commit 881f070 into OpenUserJS:master Jun 30, 2018
@Martii Martii deleted the restoreTTL branch June 30, 2018 23:52
@Martii Martii added needs mitigation Needs additional followup. and removed enhancement Something we do have implemented already but needs improvement upon to the best of knowledge. labels Jul 1, 2018
@Martii
Copy link
Member Author

Martii commented Jul 1, 2018

Needs mitigation... unpredictable results again. Trying new deps in #1477 ... could write a single timer event to auto clean similar to interval mode however current TTL didn't time me out on extension. Did when it was 6 but at times 3... so need to wait for 18 times 3... unfortunately won't be available to scan at dev station.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. DB Pertains inclusively to the Database operations. needs mitigation Needs additional followup. UI Pertains inclusively to the User Interface.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Martii