Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Single session iteration #1486

Merged
merged 1 commit into from
Jul 7, 2018
Merged

Single session iteration #1486

merged 1 commit into from
Jul 7, 2018

Conversation

Martii
Copy link
Member

@Martii Martii commented Jul 7, 2018

  • Iterate one session document at a time ... useful when we get lots of users auth'ed
  • Rename function to more like MongoDB function.
  • Very, very, very simple search algorithm... this may be expanded in later stages if applicable and probably will not be matching query feature set in MongoDB/mongoose
  • Reinvert sort order... more like on a User page listing comments instead of Discussion comments
  • Fix view to a list group a little more
  • Remove some unnecessary items from view paste
  • Remove an orphaned identifier

NOTE:

  • More changes probably ... more error checking too

Post #1446 ... related to #604

@Martii
Single session iteration
4079374 
* Iterate one session document at a time ... useful when we get lots of users auth'ed
* Rename function to more like MongoDB function.
* Very, very, very simple search algorithm... this may be expanded in later stages if applicable and probably will not be matching query feature set in MongoDB/*mongoose*
* Reinvert sort order... more like on a User page listing comments instead of Discussion comments
* Fix view to a list group a little more
* Remove some unnecessary items from view paste
* Remove an orphaned identifier

NOTE:
* More changes probably ... more error checking too

Post OpenUserJS#1446 ... related to OpenUserJS#604
@Martii Martii added bug You've guessed it... this means a bug is reported. enhancement Something we do have implemented already but needs improvement upon to the best of knowledge. UI Pertains inclusively to the User Interface. DB Pertains inclusively to the Database operations. CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. labels Jul 7, 2018
@Martii Martii merged commit 4995961 into OpenUserJS:master Jul 7, 2018
@Martii Martii deleted the singleIteration branch July 7, 2018 00:16
Martii added a commit to Martii/OpenUserJS.org that referenced this pull request Jul 7, 2018
@Martii
Move authing to last
7fde165 
Post OpenUserJS#1486
@Martii Martii mentioned this pull request Jul 7, 2018
Merged
Martii added a commit that referenced this pull request Jul 7, 2018
@Martii
Move authing to last (#1487)
b6220e9 
Post #1486 

Auto-merge
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
bug You've guessed it... this means a bug is reported. CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. DB Pertains inclusively to the Database operations. enhancement Something we do have implemented already but needs improvement upon to the best of knowledge. UI Pertains inclusively to the User Interface.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Martii