Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to non-alias xpath of xquery base for *highlight.js* dep #1529

Merged
merged 1 commit into from
Oct 14, 2018

Conversation

Martii
Copy link
Member

@Martii Martii commented Oct 14, 2018

  • Add in some dev console messages to assist

Post #1528 #1438 ; Applies to #430 ; See also highlightjs/highlight.js#1868

@Martii Martii added bug You've guessed it... this means a bug is reported. CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. dependency issue Hmmph! A dependency issue labels Oct 14, 2018
@Martii Martii merged commit a0d7a9f into OpenUserJS:master Oct 14, 2018
@Martii Martii deleted the fixUsePrimaryNameForHighlight branch October 14, 2018 23:46
@Martii
Copy link
Member Author

Martii commented Oct 15, 2018

Local pro (forced) ex.

Dependency automatic named highlighting failed with:
TypeError: Cannot read property 'disableAutodetect' of undefined

Dev ex. may contain further stack trace.

Martii added a commit to Martii/OpenUserJS.org that referenced this pull request Oct 28, 2018
* Please read their CHANGELOGs
* Revert back to alias from OpenUserJS#1529 for Code readability now that it is fixed; See also highlightjs/highlight.js#1868
* Delete op retested
@Martii Martii mentioned this pull request Oct 28, 2018
Martii added a commit that referenced this pull request Oct 28, 2018
* Please read their CHANGELOGs
* Revert back to alias from #1529 for Code readability now that it is fixed; See also highlightjs/highlight.js#1868
* Delete op retested

Auto-merge
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug You've guessed it... this means a bug is reported. CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. dependency issue Hmmph! A dependency issue
Development

Successfully merging this pull request may close these issues.

1 participant