Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always show the comment reply form #1615

Merged
merged 1 commit into from
May 30, 2019
Merged

Always show the comment reply form #1615

merged 1 commit into from
May 30, 2019

Conversation

Martii
Copy link
Member

@Martii Martii commented May 30, 2019

  • Allows some browser back button to work in certain browsers due to logoff condition. Edge use case.

NOTE:

  • This is a work-around for those browsers not implementing back-browser action in a consistent non-destructive manner. Currently present in Chromium back-ends but not Mozilla based or Safari based. Nice inconsistency google! Perhaps this is a bug to add to their collection. Probable refetch instead of cache pull (and listen) in those affected browsers which can be another imposed DoS vector.
  • No known current way, w/o additional DoS vector added, to address for newTopic logoff condition e.g. out of luck atm.

Post #1204

Refs:

@Martii
Always show the comment reply form
ae0c718 
* Allows some browser back button to work in certain browsers due to logoff condition. Edge use case.

NOTE:
* This is a **work-around** for those browsers not implementing back-browser action in a consistent non-destructive manner. Currently present in Chromium back-ends but not Mozilla based or Safari based. Nice inconsistency google! Perhaps this is a bug to add to their collection. Probable refetch instead of cache pull *(and listen)* in those affected browsers which can be another imposed DoS vector.
* No known current way, w/o additional DoS vector added, to address for newTopic logoff condition e.g. out of luck atm.

Post OpenUserJS#1204

Refs:
* https://openuserjs.org/scripts/AltoRetrato/IMDb_My_Movies_enhancer/issues/does_it_still_work!#comment-16af97e508e *(subtle report not yet done on development)*
* https://stackoverflow.com/questions/39920118/chrome-forces-page-refresh-on-window-history-back *(unanswered and long time issue)*
* OpenUserJS#1548 (comment)  *(about:flags note ... perhaps there is another one to disable bad browser acting)*
@Martii Martii added bug You've guessed it... this means a bug is reported. browser issue Surprise! It's a browser issue. labels May 30, 2019
@Martii Martii merged commit a6c8116 into OpenUserJS:master May 30, 2019
@Martii Martii added enhancement Something we do have implemented already but needs improvement upon to the best of knowledge. needs mitigation Needs additional followup. UI Pertains inclusively to the User Interface. labels May 30, 2019
@Martii Martii deleted the alwaysShowCommentReply branch May 30, 2019 23:26
@Martii
Copy link
Member Author

Martii commented May 30, 2019

Works on dev but not on pro... hmmm.

Martii added a commit to Martii/OpenUserJS.org that referenced this pull request May 31, 2019
@Martii
Missed conditional removal
a21c666 
* Misc fix indention

Applies to OpenUserJS#1615
@Martii Martii mentioned this pull request May 31, 2019
Merged
Martii added a commit that referenced this pull request May 31, 2019
@Martii
Missed conditional removal (#1616)
16325be 
* Misc fix indention

Applies to #1615

Auto-merge
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
browser issue Surprise! It's a browser issue. bug You've guessed it... this means a bug is reported. enhancement Something we do have implemented already but needs improvement upon to the best of knowledge. needs mitigation Needs additional followup. UI Pertains inclusively to the User Interface.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Martii