Differ from flagged listings; Fixes https://github.com/OpenUserJs/OpenUserJS.org/issues/178

[jerone]

Fixes #178

[Zren]

Instead of creating new booleans in the template options, why not just pass the message through?

{{^scriptList}}<tr><td>{{scriptListIsEmptyMessage}}</td></tr>{{/scriptList}}

options.scriptListIsEmptyMessage = 'No Scripts found';
if (flaggedQuery)
  options.scriptListIsEmptyMessage = 'No flagged scripts.`;

This way you can provide an ambiguous default, and refine as needed.

[jerone]

I've learned to never put content (HTML or text) in controllers, but apparently this is done everywhere I see.

I understand what you want, but don't see where to put this.
Problem is that scriptList.html is used in multiple pages, so I have to copy the logic to every controller. Or put the logic in applyModelListQueryDefaults, but not every option is available there (e.g. difference between libraries & scripts).
Any suggestions?

Edit:
I have the following code for the users logic in file user.js in export userListPage in function preRender:

    // Empty list
    options.userListIsEmptyMessage = 'No users.';
    if (options.isFlagged) {
      options.userListIsEmptyMessage = 'No flagged users.';
    } else if (options.searchBarValue) {
      options.userListIsEmptyMessage = 'We couldn\'t find any users by this name.';
    }

[Martii]

so I have to copy the logic to every controller.

I've noticed this too for another RFE I'll be posting at some point. Mine is just a need/want for a global boolean flag so mustache/html can keep "logic-less" and simple as possible. I think we could definitely use a "global" controller for all controllers inserted with require and start using some of the "publicly zoned namespace scope" a bit more (export like). In iW and CI I use the prefix of gWhatever to denote global identifiers but still within the IIFE.

[jerone]

So I just moved the empty lists message to the corresponding controllers. Ready for another review or merge...

[Martii]

+1 tested in dev. Thanks for noticing the line note and fixing this one. :) I wasn't sure if anyone would see it on the upstream merge commit or not... GH kept trying to send me to your repo with that commit hash... but I finally got it on the merge commit.