Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some encoding issues #1855

Merged
merged 1 commit into from
Nov 22, 2021
Merged

Fix some encoding issues #1855

merged 1 commit into from
Nov 22, 2021

Conversation

Martii
Copy link
Member

@Martii Martii commented Nov 22, 2021 •
edited
Loading

  • Now I recall some of it... Percent wasn't excluded in cleanFilename so we have to double check things. MongoDB doesn't care neither does AWS... but browsers do.

Post #1847 and applies to #200

NOTE:

  • Test script RFC§ (inverse) and n%

May need this in DOM for username too... leaving as a test atm.

@Martii
Fix some encoding issues
4395356 
* Now I recall some of it... Percent wasn't excluded in `cleanFilename` so we have to double check things. MongoDB doesn't care neither does AWS... but browsers do.

Post OpenUserJS#1847 and applies to OpenUserJS#200

NOTE:
* Test script RFC and n%
@Martii Martii added bug You've guessed it... this means a bug is reported. enhancement Something we do have implemented already but needs improvement upon to the best of knowledge. UI Pertains inclusively to the User Interface. CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. browser issue Surprise! It's a browser issue. labels Nov 22, 2021
@Martii Martii merged commit 4fdf4fa into OpenUserJS:master Nov 22, 2021
@Martii Martii deleted the Issue-944urlTestForEncode branch November 22, 2021 07:05
@Martii Martii added the needs testing Anyone can add this but it is primarily there for the Assignee indicating that Testers are wanted. label Nov 22, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
browser issue Surprise! It's a browser issue. bug You've guessed it... this means a bug is reported. CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. enhancement Something we do have implemented already but needs improvement upon to the best of knowledge. needs testing Anyone can add this but it is primarily there for the Assignee indicating that Testers are wanted. UI Pertains inclusively to the User Interface.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Martii