Fix a potential server trip #1912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Trap User callback WARNING note to fix the bug. * Some show only what is needed on server errors. * Make some failures/notices a little softer with notifications *(reminders)*. Trying timeouts... a little odd but occasionally works. * Adjust timing to zero. Chromium base is having issues with `5` on dev. Will try this for a bit. Post OpenUserJS#1910 Post OpenUserJS#1446 OpenUserJS#944
Martii
added
bug
Martii
added a commit
to Martii/OpenUserJS.org
that referenced
this pull request
Dec 30, 2021
* options.redirectTo is overwritten somewhere else later in the code... so use a unique options value. Needs further retesting. * Eliminate some dupe code. * Rename some strings. * Split out an error trap * Fix unclosed handlebar... interesting that *mustache* didn't catch this and even more weird that it still worked! Post OpenUserJS#1912
Merged
Martii
added a commit
that referenced
this pull request
Dec 30, 2021
* options.redirectTo is overwritten somewhere else later in the code... so use a unique options value. Needs further retesting. * Eliminate some dupe code. * Rename some strings. * Split out an error trap * Fix unclosed handlebar... interesting that *mustache* didn't catch this and even more weird that it still worked! Post #1912 Auto-merge
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
5on dev. Will try this for a bit. Post Update timings and enhance #1910Post #1446 #944