Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add basic support for (site/project) key prefixing #226

Merged
merged 9 commits into from
Jun 29, 2014
Merged

Add basic support for (site/project) key prefixing #226

merged 9 commits into from
Jun 29, 2014

Commits on Jun 29, 2014

  1. Add basic support for key prefixing 

    * Some variable standardization to help me and others be able to read the code better.
* Moved output whitespace to a variable so we can tweak it when/if necessary.
* Bug fix on extra white space added for imperitaves. e.g. no data values.
* Define a few missing variables... would be nice if V8 would warn on this
* Enable toggling of the `true` on `uniques`... e.g. if you toggle it to false it will be ignored.

**TODO**:
1. Find the code for collaboration and...
2. Break `@collaborator` and `@author` ... but fix it too. ;)
3. Prefix `@collaborator` and `@author` with `oujs`... thus making `@oujs:author` and `@oujs:collaborator`
    Martii committed Jun 29, 2014
    Configuration menu
    Copy the full SHA
    b217490 View commit details
    Browse the repository at this point in the history

  2. Readd @author... need this for testing 

    Applies to OpenUserJS#226 and OpenUserJS#208
    Martii committed Jun 29, 2014
    Configuration menu
    Copy the full SHA
    5134914 View commit details
    Browse the repository at this point in the history

  3. Swap out @collaborator and @author for prefixed keys 

    * Needs total verification that I haven't missed something.
* I do have some redundant tests in for `meta.oujs` existence but I'll remove those on demand.
* Hopefully this is everything needed.

Applies to OpenUserJS#226 and OpenUserJS#208
    Martii committed Jun 29, 2014
    1 Configuration menu
    Copy the full SHA
    b6fd452 View commit details
    Browse the repository at this point in the history

  4. Remove some duplicated meta.oujs checks... the remaining one should… 

    … probably stay in there since it's an `||`

Applies to OpenUserJS#226 via OpenUserJS#208
    Martii committed Jun 29, 2014
    Configuration menu
    Copy the full SHA
    550993d View commit details
    Browse the repository at this point in the history

  5. Change add/scripts page to reflect these changes. 

    * Removed text `Only the author may edit.` from `@author`... that doesn't make sense to me... but did put in `Required to enable Collaboration` change.

Applies to OpenUserJS#226 via OpenUserJS#208
    Martii committed Jun 29, 2014
    Configuration menu
    Copy the full SHA
    42f9c30 View commit details
    Browse the repository at this point in the history

  6. Missed an instruction on the page to use prefix 

    Applies to OpenUserJS#226 via OpenUserJS#208
    Martii committed Jun 29, 2014
    Configuration menu
    Copy the full SHA
    f7ff675 View commit details
    Browse the repository at this point in the history

  7. I could have swore that this was committed a few days ago... No idea … 

    …how this crept back in... SF changed their wiki store... correcting links to the new path and removing from specifics

Applies to the esrs.
    Martii committed Jun 29, 2014
    Configuration menu
    Copy the full SHA
    d6f4302 View commit details
    Browse the repository at this point in the history

  8. Missed identifier change 

    * Mentioned in OpenUserJS#226 (comment)

Thanks Jerone :)

Applies to OpenUserJS#226 via OpenUserJS#208
    Martii committed Jun 29, 2014
    Configuration menu
    Copy the full SHA
    b4bde68 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'master' into allowPrefixedMetadataKeys 

    Conflicts:
	controllers/script.js
	views/pages/newScriptPage.html

Resolved... favor newer ones
    Martii committed Jun 29, 2014
    Configuration menu
    Copy the full SHA
    c9e5e0e View commit details
    Browse the repository at this point in the history