-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Script.installsSinceUpdate & show in author panel. #333
Conversation
👍 This is similar to what I was trying to explain when I created this google group thread. |
+1 for sure here... really difficult to do some admin duties and this is a step in the right direction for that. I ran into a situation within the last few days that I couldn't tell what script came first too. e.g. author wise from two authors. I have yet to find a "signedup date" for the author... so my only remedy currently is to flag them both and let them sort it out. :\ |
Btw is installs versus the version backwards? I noticed on absent |
Er... it was Installs per Version before I shortened it to a slash. I guess that might be confusing. I could tack on "installs" at the end. Eg: |
Would probably be better for translations too. |
bd2fe57
to
7bcd822
Compare
Wouldn't it be more useful to have some sort of history table (including e.g. source changes). |
👍 Been wanting this for so long :) |
This portion needs to be team biz as well as someone needs to assign them self to it as "chair person". Sizzle has already stated that we ~"may have changelogs" but it's not the first and foremost on his mind nor mine. e.g. commit history may be a MIGHTFIX. |
Yes, but that's a lot more work than 10 lines of code that this entails. Added PR Ready for these both my PRs. |
Still seems like it is going to confuse those new to the site EDIT: perhaps expecting a ratio or percent. You say "Installs / Versions" (assume you mean "per" here) but underneath it is shows " |
@Martii commented on 2 sep. 2014 05:59 CEST:
I agree. My preference goes to using the following as it's not an mathematical formula:
Needs to change the "since" date too when going live:
|
I think moment can be used to format it to however we want it for each locale eventually... but you are right. I'm translating the dev page with a few translators just to see how it "looks"... I don't know every foreign language but it may translate back and forth better in clearer sentence type structures. |
@Martii commented on 2 sep. 2014 10:13 CEST:
Using Moment.js here sounds like a good solution. Later, when we implement i18n (#18), we can add a locale key as the third parameter. |
It was in both of the screenshots, but whatever, may as well since I'm updating the date anyways. Moment is used for formatting Date objects, which we're not doing. If i18n ever gets implemented, treat it as a regular string you need to translate (if the warning is even still needed in that distant future). |
7bcd822
to
6621ee5
Compare
2 Sept 2014 & per done. |
@Zren commented on 2 sep. 2014 11:04 CEST:
Don't forget the |
LOL @jerone We're all here right now and checking this out so I can make the exception this one time but yes it should be done. I just tested it and it looks good. |
Add Script.installsSinceUpdate & show in author panel.
btw did anyone notice GH seems to have made a change on cumulative changes in a pr to only show one commit now? e.g. Zrens commits (all 3 of them for this pr) are only referenced once now... at least here. |
That's because I did This way, only one commit actually gets merged. |
Interesting. That might keep things tidy but terrible for teaching... and referencing. |
This only tracks the current version right now.
This is one method of creating a useful install count. We could expand on this by adding another property with
{ type: Object }
that contains{ version: installCount, version: installCount }
.Only shown in the author panel for now.