Insert a BOM check for import and file upload #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Similar to @janekptacijarabaci fix in greasemonkey/greasemonkey#1940 * Fix compliance with STYLEGUIDE.md and usage of pre-initialized identifiers * Currently **do not** propagate BOM with meta routine or user.js source with and without installation count increment * BOM currently shows up in Ace as a exclamation triangle with "This character may get silently deleted by one or more browsers" **NOTE**: Many thanks to the report by @cvzi and applies to OpenUserJS#200 and partially outlined in OpenUserJS#198.
Martii
added
bug
Martii
added a commit
that referenced
this pull request
Sep 11, 2014
Insert a BOM check for import and file upload
Martii
removed
the
PR READY
Martii
pushed a commit
to Martii/OpenUserJS.org
that referenced
this pull request
Oct 5, 2015
…keeps things consistent *hopefully* * Using uppercase as mentioned at OpenUserJS#198 (comment) Applies to OpenUserJS#678 Related to: * OpenUserJS#348 discovery * OpenUserJS#200 * OpenUserJS#198
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
or user.js source with and without installation count increment(whoops it does the part striked out by default but everyone should get my point with the meta routine... e.g. doesn't appear to be needed in there)NOTE: Many thanks to the report by @cvzi and applies to #200 and partially outlined in #198.
Tested on dev with this script in
Mozilla/5.0 (X11; Linux x86_64; rv:32.0) Gecko/20100101 Firefox/32.0