Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly use Buffer length instead of String length for "Chunking" #762

Merged
merged 1 commit into from
Oct 6, 2015
Merged

Correctly use Buffer length instead of String length for "Chunking" #762

merged 1 commit into from
Oct 6, 2015

Conversation

Martii
Copy link
Member

@Martii Martii commented Oct 6, 2015

  • Thanks to a node maintainer for the clarification at Possible Buffer.concat documentation vagueness nodejs/node#3219 of Buffer length versus character length
  • Retested on a User Script that contained a lot of Unicode characters in a comment at the beginning then the metadata blocks at the EOF... String.length fails to upload... Buffer length passes on upload with two "chunks"

Applies to #678

Correctly use Buffer length instead of String length for "Chunking"
a76bb59 
* Thanks to *node* maintainer for the clarification at nodejs/node#3219 of Buffer length versus character length
* Retested on a User Script that contained a lot of Unicode characters in a comment at the beginning then the metadata blocks at the EOF... String.length fails to upload... Buffer length passes on upload with two "chunks"

Applies to OpenUserJS#678
@Martii Martii added bug You've guessed it... this means a bug is reported. enhancement Something we do have implemented already but needs improvement upon to the best of knowledge. labels Oct 6, 2015
Martii added a commit that referenced this pull request Oct 6, 2015
@Martii
Merge pull request #762 from Martii/Issue-678useBufferLengthInsteadOf…
c89e68f 
…StringLength

Correctly use Buffer length instead of String length for "Chunking"

Auto-merge
@Martii Martii merged commit c89e68f into OpenUserJS:master Oct 6, 2015
@Martii Martii deleted the Issue-678useBufferLengthInsteadOfStringLength branch October 6, 2015 22:13
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
bug You've guessed it... this means a bug is reported. enhancement Something we do have implemented already but needs improvement upon to the best of knowledge.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Martii