-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup admin controller file #810
Conversation
* Don't use `options` for JSON and plain text outputs instead use module helper ... faster/cleaner... this is also a Unit Test in this area as well as OpenUserJS#249 checking * Added watchpoint for OpenUserJS#200 with `encodeURI` * Only time I've encounter `nil` helper function **so far**... added notation on inconsistency and since it's the only helper function used at this time in this file condensed the `require` * Added watchpoint for an encountered special render op... first I've seen of these so far... I know what the output looks like but unable to find a matching view for it other than it's visual reference in Admin Tools **NOTES** * Questions to follow * One TODO to finish depending on answers Originally applies to OpenUserJS#262 ... not part of OpenUserJS#262 (comment)
@@ -86,7 +102,7 @@ exports.userAdmin = function (aReq, aRes, aNext) { | |||
}); | |||
}); | |||
|
|||
aRes.render('userAdmin', options); | |||
aRes.render('userAdmin', options); // NOTE: Watchpoint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do either one of you know where this physical view is? The docs for express res.render (and related app.render) don't seem to cover this.
Refs:
- current paged views list
- current included views list
- current views folder list
- Only thing that comes close is
./views/includes/userAdminToolsPanel.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahhh so dead code from a different code migration... Thank you!
* Remove NOTEs about inconsistent usage... actual function module exports these out... so comment isn't quite accurate on helper function... keeping as is * Remove dead code/comment from prior code migrations/implementations Originally applies to OpenUserJS#262 ... not part of OpenUserJS#262 (comment) Post fix for OpenUserJS#810
Cleanup admin controller file Auto-merge
options
for JSON and plain text outputs instead use module helper ... faster/cleaner... this is also a Unit Test in this area as well as Establish a build/exec/deploy system #249 checkingencodeURI
Only time I've encounternil
helper function so far... added notation on inconsistency and since it's the only helper function used at this time in this file condensed therequire
Added watchpoint for an encountered special render op... first I've seen of these so far... I know what the output looks like but unable to find a matching view for it other than it's visual reference in Admin ToolsNOTES
Questions to followOne TODO to finish depending on answersOriginally applies to #262 ... not part of #262 (comment)