Add *kerberos* dep even though we don't use it #834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* This removes the warning/error on `npm install` Ref: * https://github.com/mongodb/node-mongodb-native/blob/2db9984f5972ff1916f46f1aab025373444aa39d/README.md#diagnosing-on-unix ... not quite what I was expecting but will still need followup when we get to *node*@6.x LTS Applies to OpenUserJS#832 and may need further mitigation on *node* LTS upgrade next year. Closes jdesboeufs/connect-mongo#203 *(not sure if this will close automatically but need the reference anyhow)*
Martii
added
bug
Martii
added a commit
that referenced
this pull request
Nov 19, 2015
Add *kerberos* dep even though we don't use it Auto-merge
|
Hmmm that did work on closing a remote issue... kewl. :) |
Martii
pushed a commit
to Martii/OpenUserJS.org
that referenced
this pull request
Nov 19, 2015
* While this still seems hacky with MongoDB support backend structures we can possibly minimize the impact here for future top-level "dep hell" by making this optional... too bad [`peerDependencies`](https://docs.npmjs.com/files/package.json#peerdependencies) with *npm*@3.x made a change where it does **not** download it... seems like they ought to make a new property name in *npm* to handle this situation. Post fix for OpenUserJS#834
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm installRef:
Applies to #832
Closes jdesboeufs/connect-mongo#203 (not sure if this will close automatically but need the reference anyhow)
Additional refs:
NOTE TO SELF:
gss