Change some more defaults with MongoDB #854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Change logic to only use `replset` on production ... as per Automattic/mongoose#3588 (comment) from @chrisckchang * Default to single connection on development with `server` ... as per Automattic/mongoose#3588 (comment) from @chrisckchang * Change `connectTimeoutMS` to 60 seconds instead of presumed inherited OS value from https://github.com/christkv/mongodb-core/issues/66#issuecomment-165052045 by @christkv and overridden with @chrisckchang recommendation previously mentioned in commit summary. * Added NOTE on non-standard keepAlive value that was in before I started twiddling with this... this was on dev and pro pre replica/sharding set. Applies to OpenUserJS#845, OpenUserJS#851, OpenUserJS#852, Automattic/mongoose#3588 and loosely christkv/mongodb-core#66 Refs: * Automattic/mongoose#3588 (comment)
Martii
added
bug
Martii
added a commit
that referenced
this pull request
Dec 18, 2015
Change some more defaults with MongoDB Auto-merge
|
MITIGATION: Move |
Martii
pushed a commit
to Martii/OpenUserJS.org
that referenced
this pull request
Dec 18, 2015
* Followup ... also flipping test from OpenUserJS#854 * Match `keepAlive` settings from legacy value and add a note there as well * Delete op tested
Merged
2015-12-18 10:53:02.288 +00:00: Error: connect ENETUNREACH *IPV6_ADDRESS_CLIPPED* - Local (:::0)
2015-12-18 10:53:02.295 +00:00: InternalOAuthError: Failed to obtain access token
at Strategy.OAuth2Strategy._createOAuthError (~/OpenUserJS.org/node_modules/passport-google-oauth/node_modules/passport-oauth/node_modules/passport-oauth2/lib/strategy.js:348:17)
at ~/OpenUserJS.org/node_modules/passport-google-oauth/node_modules/passport-oauth/node_modules/passport-oauth2/lib/strategy.js:171:43
at ~/OpenUserJS.org/node_modules/passport-google-oauth/node_modules/passport-oauth/node_modules/passport-oauth2/node_modules/oauth/lib/oauth2.js:177:18
at ClientRequest.<anonymous> (~/OpenUserJS.org/node_modules/passport-google-oauth/node_modules/passport-oauth/node_modules/passport-oauth2/node_modules/oauth/lib/oauth2.js:148:5)
at emitOne (events.js:77:13)
at ClientRequest.emit (events.js:169:7)
at TLSSocket.socketErrorListener (_http_client.js:259:9)
at emitOne (events.js:77:13)
at TLSSocket.emit (events.js:169:7)
at emitErrorNT (net.js:1253:8)
at doNTCallback2 (node.js:441:9)
at process._tickDomainCallback (node.js:396:17)... weird, possible resultant, from inverse test.. flipped to normalized in #855 ... retested Google login and checks okay. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replseton production ... as per Failure To Reconnect After A Socket Closed Error Automattic/mongoose#3588 (comment) from @chrisckchangserver... as per Failure To Reconnect After A Socket Closed Error Automattic/mongoose#3588 (comment) from @chrisckchangconnectTimeoutMSto 60 seconds instead of presumed inherited OS value from https://github.com/christkv/mongodb-core/issues/66#issuecomment-165052045 by @christkv and overridden with @chrisckchang recommendation previously mentioned in commit summary.keepAlivevalue that was in before I started twiddling with this... this was on dev and pro pre replica/sharding set.Applies to #845, #851, #852, Automattic/mongoose#3588 and loosely christkv/mongodb-core#66
Refs: