Fix some bugs with encoding #900
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove the patch I put in for this portion * Create function for encoding like GH's... see helper `encoding` * Using encodeURIComponent from OpenUserJS#795 * Fix bug of Fork History showing "slugged" instead of native/raw * Fix a missing model parser item for `category` virtual model * Fix some more bugs in modelParser.js * Transform a watchpoint with AuthAs ... see third alternative at http://stackoverflow.com/questions/15825333/how-to-reload-current-page-in-express-js with `aRes.redirect(req.get('referer'));` or *express*@4.x shortcut of `aRes.redirect('back');`... but if referer is missing will default to `/` Ref: http://expressjs.com/en/api.html#res.redirect ... this still appears to be a bug in *express* for quite some time so this is a workaround * Add another series of watchpoints with *express*@4.x `redirect()` doing `escape` on occasion ... special handling of `redirect`.... this particular bug doesn't appear to make much sense * Project version bump **NOTES** * Followup with DB migration to add `fork.utf` to existing forks otherwise they show up as `/` * Followup with `discussion.path` fixes. * If *express* fixes their redirect issue can simplify `encode` to be a smarter encode where it only encodes when needed... which is where it started but had to back that out in this PR * Leaving GH import alone as it still works so far * `./app.js` has one `encodeURI` in it... leaving that be for the time being until it can be retested on production... dev isn't https so no way to test here Applies to OpenUserJS#819 and OpenUserJS#262... treads on OpenUserJS#262 (comment) among many others.
Martii
added
bug
Martii
added
migration
Member
Author
|
ON HOLD... may have a fourth option that's a little clearer and retains some original functionality. |
Member
Author
|
Abandoning for a newer PR... it should preserve more... so far so good... about 90% tested and 85% code transformed... within current code styling. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
encodingcategoryvirtual modelaRes.redirect(req.get('referer'));or express@4.x shortcut ofaRes.redirect('back');... but if referer is missing will default to/Ref: http://expressjs.com/en/api.html#res.redirect ... this still appears to be a bug in express for quite some time so this is a workaroundredirect()doingescapeon occasion ... special handling ofredirect.... this particular bug doesn't appear to make much senseNOTES
fork.utfto existing forks otherwise they may show up as/(or a list bullet) Array typed values write themselves... interesting.discussion.pathfixes. (ready)encodeto be a smarter encode where it only encodes when needed... which is where it started but had to back that out in this PR./app.jshas oneencodeURIin it... leaving that be for the time being until it can be retested on production... dev isn't https so no way to test hereApplies to #819 and #262... treads on #262 (comment) among many others.