Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mirror paginations at top #531

Closed
Martii opened this issue Jan 13, 2015 · 5 comments · Fixed by #543
Closed

Mirror paginations at top #531

Martii opened this issue Jan 13, 2015 · 5 comments · Fixed by #543
Labels
enhancement Something we do have implemented already but needs improvement upon to the best of knowledge. UI Pertains inclusively to the User Interface.

Comments

@Martii
Copy link
Member

Martii commented Jan 13, 2015

So it's about time to reconsider and revisit this. This should be relatively simple to duplicate but I wanted to read what others had to say about this.

@BastianKanaan might want to pipe in here since that script has the largest discussion to date that I've seen on OUJS.
@Martii Martii added enhancement Something we do have implemented already but needs improvement upon to the best of knowledge. team biz This is similar to a meta discussion. UI Pertains inclusively to the User Interface. sooner Sooner would be appreciated. labels Jan 13, 2015
@Martii Martii self-assigned this Jan 13, 2015
@Martii Martii removed the team biz This is similar to a meta discussion. label Jan 14, 2015
Martii pushed a commit to Martii/OpenUserJS.org that referenced this issue Jan 14, 2015
Add top pagination with some more symmetry in the UI
113f426 
* `bootstrap-custom.css` needs some more tweaking as we have some slight pixel related CSS issues overall but will save that for another PR
* Add "Categories" header to main forum page
* Change "Discuss" labels to "Discussions" to match title... we have plenty of room
* Expand out "Libs" to "Libraries" ... again we have room with *bootstrap* and portable devices. Needed for translations in OpenUserJS#18
* Change a few tooltips to match
* Adjust comment reply popup size to match changes

Applies to OpenUserJS#531
@Martii Martii mentioned this issue Jan 14, 2015
Merged
@Martii Martii added needs discussion Blah, blah, blah, wahh, wahh, wahh, etc. tracking upstream Waiting, watching, wanting. labels Jan 14, 2015
@jerone
Copy link
Contributor

jerone commented Jan 14, 2015

From a design/layout perspective in my opinion I'm 👎 on this; 1, 2, 3

@Martii
Copy link
Member Author

Martii commented Jan 14, 2015

Try that link on a portable device with the URL I posted above and might change your mind. Nobody in their right mind would want to swipe that many times on a touch screen... ever heard of carpal tunnel?! ;)

I'm still tweaking which is why this is still open. Yes there will be some more white space to dark space in that area... the advantage of being able to go to the end supersedes visual eye-candy (screen real estate) in this case.

Sizzle already gave the thumbs up and I agree with it. I'll do my best to minimize the gaping gaps that have been recently introduced (started in #477 and beyond) but it will take some time to iron out.

Thanks for the links... 3 seems to be the most readable and logical so far.

@jerone
Copy link
Contributor

jerone commented Jan 14, 2015

@Martii commented on 14 jan. 2015 09:13 CET:

Try that link on a portable device with the URL I posted above and might change your mind. Nobody in their right mind would want to swipe that many times on a touch screen... ever heard of carpal tunnel?! ;)

Valid use case; then use Bootstrap for only showing on small devices.

@Martii
Copy link
Member Author

Martii commented Jan 14, 2015

And ones scroll finger on their desktop, which isn't a small device, invalidates that completely. All reputable forum softwares have pagination to the end immediately. The concept of making one scroll to the end of a page just to get to pagination is, digressing for a moment, quite frankly moronic. :)

then use Bootstrap for only showing on small devices.

Just as FYI you of all people should already know we use some of that already... incorrectly in a few portions of the code too but manageable.

Martii pushed a commit to Martii/OpenUserJS.org that referenced this issue Jan 14, 2015
Fix the bottom existing pagination at /forum
3af3cc4 
* Panel was initialized with pagination that skewed off center for additions and compounded by OpenUserJS#443. This should align the existing pagination properly.

Applies to OpenUserJS#531
@Martii Martii mentioned this issue Jan 14, 2015
Merged
Martii pushed a commit to Martii/OpenUserJS.org that referenced this issue Jan 16, 2015
Use jQuery to show top pagination on scroll down then scroll up
1087e0e 
* Some STYLEGUIDE.md conformance
* Wrap in IIFE's to keep these things out of the global environment content scope... some packages could use our identifier names and collide.
* Faster and concurrent hide of comment reply box with spacer resize

Applies to OpenUserJS#531
@Martii Martii mentioned this issue Jan 16, 2015
Merged
@Martii
Copy link
Member Author

Martii commented Jan 16, 2015

Anything else before closing?

I don't know if anyone would want paginationRendered to not show if there is only one (1) page. I twiddled with that portion locally already so it's an option in rewriting the template and views. e.g. could be done relatively easily.

Martii pushed a commit to Martii/OpenUserJS.org that referenced this issue Jan 19, 2015
Programmatic toggle and disable only page pagination
f0a6594 
* Don't send the jQuery script if no more pages
* Adjust comment reply box value to accommodate on the fly
* This also allows some fixing of rendering on pages that have no items in the list e.g. too far out in `p` QSP.

Closes OpenUserJS#531

**MISC NOTE**:
* Existing `pagination` object is "late" object creation e.g. accumulation of it's properties and methods occurs from iteration through existing methods and `lastPage` is calculated near the end of the process.
@Martii Martii mentioned this issue Jan 19, 2015
Merged
@Martii Martii removed needs discussion Blah, blah, blah, wahh, wahh, wahh, etc. sooner Sooner would be appreciated. labels Jan 19, 2015
@Martii Martii removed their assignment Jan 28, 2015
@Martii Martii removed the tracking upstream Waiting, watching, wanting. label Jan 28, 2015
@OpenUserJS OpenUserJS locked as resolved and limited conversation to collaborators Apr 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement Something we do have implemented already but needs improvement upon to the best of knowledge. UI Pertains inclusively to the User Interface.
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Programmatic toggle and disable only page pagination Martii/OpenUserJS.org
2 participants
@jerone @Martii