Added reverse sorting for all listings.

[jerone]

Fixes #292

Added reverse sorting to listings:

• scripts
• script issues
• libraries
• library issues
• groups
• group scripts
• (sub)discussions
• users
• user scripts
• user issues
• flagged scripts
• flagged libraries
• flagged users
• graveyard

Also fixed ordering Removed By in Removed Items list;

[Martii]

Bug on

• http://localhost:8080/mod/removed?orderBy=remover&orderDir=desc vs http://localhost:8080/mod/removed?orderBy=remover&orderDir=asc

[jerone]

@Martii commented on 21 aug. 2014 21:07 CEST:

Bug on

• http://localhost:8080/mod/removed?orderBy=remover&orderDir=desc vs http://localhost:8080/mod/removed?orderBy=remover&orderDir=asc

Actually this is not a bug, but should the sorting be removed on that column (Removed By). Same issue as with #306 (comment)

[Martii]

When removed by shows "Marti" at the top and "Zren" at the bottom and one clicks sort by remover... "Zren" should move up to the top. So yes it is a bug. :)

[jerone]

@Martii commented on 21 aug. 2014 21:17 CEST:

When removed by shows "Marti" at the top and "Zren" at the bottom and one clicks sort by remover... "Zren" should move up to the top. So yes it is a bug. :)

Oke, it's a bug. It was a bug before this PR and to my opinion out of the scope of this PR. You are free to make an issue and submit a PR to remove this column ordering if you want.

[Martii]

Why not fix it now so your PR is not blocked by this? ... You are in this code area.

[Zren]

removerName instead of remover

[jerone]

@Zren commented on 21 aug. 2014 21:27 CEST:

removerName instead of remover

YES, that fixed it. Will add it to this PR.

[Martii]

Btw how do we increment the install count for libs?

[Martii]

Is http://localhost:8080/?orderBy=updated&orderDir=desc&flagged=true backwards terminology wise? ... in general "Last Update"? n/m

[jerone]

Will add it to this PR.

Hmm weird, just pushed this fix to my branch but doesn't show up here...

[Martii]

doesn't show up here

Have to put a #309 in your commit summary. ...Could be your master is off too. GH is kind of weird in this area.

[jerone]

@Martii commented on 21 aug. 2014 21:53 CEST:

doesn't show up here

Have to put a #309 in your commit summary. ...Could be your master is off too. GH is kind of weird in this area.

I think I started this PR wrong.
At the bottom of the PR it's also saying Add more commits by pushing to the issue-292 branch on OpenUserJs/OpenUserJS.org. which should have been jerone/OpenUserJS.org.

[Martii]

Yah I see that now... you did it directly on OUJS instead of doing it on your fork first.

[jerone]

@Martii commented on 21 aug. 2014 22:00 CEST:

Yah I see that now... you did it directly on OUJS instead of doing it on your fork first.

Don't know how, but probably how my tool makes a PR. Won't do that again. Anyway, fix is now added to this PR.

[Martii]

Adding bug label so we can merge this eventually. So I'm guessing my question will remain unanswered? It's difficult to test the sort order on libs if there's no install count other than zero. ;)

---

+1 Tests okay minus the lib install count since they are all zero heh... Nice job... PR READY still? @jerone

[Martii]

These are minor but could be useful to fix...

{{{ versus using {{ in the mustache views. Is there a reason why you are unescaping the &xx; values?

Also pushing it right to the line with your var statement not being first in the function here. ;) :)

Unmarking as PR ready since you didn't answer earlier. :P :)