-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TLS key system v1 #1185
Merged
Merged
TLS key system v1 #1185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TinCanTech
force-pushed
the
tls-key-system-v1
branch
from
July 6, 2024 23:54
dadf1ad
to
4348096
Compare
TinCanTech
force-pushed
the
tls-key-system-v1
branch
2 times, most recently
from
July 8, 2024 01:33
a3eb4b2
to
05dfccb
Compare
Signed-off-by: Richard T Bonhomme <tincantech@protonmail.com>
…PT-V1 Signed-off-by: Richard T Bonhomme <tincantech@protonmail.com>
…RYPT-V1 Signed-off-by: Richard T Bonhomme <tincantech@protonmail.com>
TinCanTech
force-pushed
the
tls-key-system-v1
branch
from
August 17, 2024 13:59
05dfccb
to
6e9e4a2
Compare
Signed-off-by: Richard T Bonhomme <tincantech@protonmail.com>
TinCanTech
added
enhancement
Version 3.2.1-Release
ChangeLog Item
and removed
development
Possible changes
labels
Aug 17, 2024
Signed-off-by: Richard T Bonhomme <tincantech@protonmail.com>
Inlining files is only suitable for OpenVPN, therefore, inlining should only be done for recognized certificate types |
Add OpenVPN --key-direction for TLS-AUTH keys. Signed-off-by: Richard T Bonhomme <tincantech@protonmail.com>
Signed-off-by: Richard T Bonhomme <tincantech@protonmail.com>
Only inline TLS Keys for certificate type 'server' and 'client'. Signed-off-by: Richard T Bonhomme <tincantech@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1121
Note: There is no unit test for
gen-tls-*-key
because OpenVPN may not be installed on GHA. Also, the command is simple enough that a unit test is not required. However, unit testing the inlining of a TLS key will be advantageous (OpenVPN/easyrsa-unit-tests#62).