Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inline v2 #1201

Merged
merged 31 commits into from
Aug 6, 2024
Merged

Inline v2 #1201

merged 31 commits into from
Aug 6, 2024

Conversation

TinCanTech
Copy link
Collaborator

@TinCanTech TinCanTech commented Aug 5, 2024 •
edited
Loading

The only noticeable changes are:

  • Certificate fingerprint is always included in the header.
  • Certificate Type is removed from the header.
  • Redirecting output to a user named file is no longer supported.
  • Existing inline files are always over-written.

@TinCanTech
Introduce inline_file(): Rewrite and simplify inlining routine
823f70f 
Signed-off-by: Richard T Bonhomme <tincantech@protonmail.com>
@TinCanTech
sign-req: Use inline_file() - build_full: Do not use inline_creds()
6a0ebb8 
Signed-off-by: Richard T Bonhomme <tincantech@protonmail.com>
@TinCanTech
Remove inline_creds(), replaced by inline_file()
b62986c 
Signed-off-by: Richard T Bonhomme <tincantech@protonmail.com>
@TinCanTech
Select inline_file() for command 'inline'
de0c796 
Signed-off-by: Richard T Bonhomme <tincantech@protonmail.com>
@TinCanTech
inline: Disable EASYRSA_SILENT, no longer required
17a759b 
Signed-off-by: Richard T Bonhomme <tincantech@protonmail.com>
@TinCanTech TinCanTech self-assigned this Aug 5, 2024
@TinCanTech TinCanTech added this to the v3.2.1 milestone Aug 5, 2024
@TinCanTech TinCanTech linked an issue Aug 5, 2024 that may be closed by this pull request
sign-req does not build an inline file #1200
Closed
@TinCanTech
inline_file(): Provide full header details
6f366e6 
Signed-off-by: Richard T Bonhomme <tincantech@protonmail.com>
@TinCanTech
ChangeLog: Move auto-inline from build_full() to sign_req()
853f172 
Signed-off-by: Richard T Bonhomme <tincantech@protonmail.com>
@TinCanTech
Inline self-sign certificate: Use new inline_file() function
52022d9 
Requires ssl_cert_x509v3_eku(): Check for self signed certificate.

Signed-off-by: Richard T Bonhomme <tincantech@protonmail.com>
@TinCanTech
inline: Update help
6833d83 
Signed-off-by: Richard T Bonhomme <tincantech@protonmail.com>
@TinCanTech
revoke_move(): Simplify and use '-f' for file existence check
6ab98c9 
Signed-off-by: Richard T Bonhomme <tincantech@protonmail.com>
@TinCanTech
expire_cert(): Use '-f' for file existence check
b71028d 
Signed-off-by: Richard T Bonhomme <tincantech@protonmail.com>
@TinCanTech
locate_support_files(): Use '-d' and '-f'
321a2c0 
 for dir/file existence check

Signed-off-by: Richard T Bonhomme <tincantech@protonmail.com>
@TinCanTech TinCanTech linked an issue Aug 6, 2024 that may be closed by this pull request
Switch to -f for file existence and simplify use of easyrsa_mkdir #1202
Closed
@TinCanTech
build_ca(): Simplify use of easyrsa_mkdir
42feab3 
Signed-off-by: Richard T Bonhomme <tincantech@protonmail.com>
@TinCanTech
self_sign(): Simplify and use '-f' for file existence
1c53ca0 
Signed-off-by: Richard T Bonhomme <tincantech@protonmail.com>
@TinCanTech
gen_dh(): Use '-f' for file existence and correct indentation
24dcd55 
Signed-off-by: Richard T Bonhomme <tincantech@protonmail.com>
@TinCanTech
sign_req(): Simplify and use '-f' for file exitence
9f6cf24 
Signed-off-by: Richard T Bonhomme <tincantech@protonmail.com>
@TinCanTech
build_full(): Use '-f' for file existence and drop existing inline check
41e87dd 
Signed-off-by: Richard T Bonhomme <tincantech@protonmail.com>
@TinCanTech
inline_file(): Use '-f' for file existence
8882eba 
Signed-off-by: Richard T Bonhomme <tincantech@protonmail.com>
@TinCanTech
revoke(): Use '-f' for file existence and remove excess '{}' braces
86f1208 
Signed-off-by: Richard T Bonhomme <tincantech@protonmail.com>
@TinCanTech
import_req(): Use '-f' for file existence
9dddda9 
Signed-off-by: Richard T Bonhomme <tincantech@protonmail.com>
@TinCanTech
set_pass(): Use '-f' for file existence
962c68f 
Signed-off-by: Richard T Bonhomme <tincantech@protonmail.com>
@TinCanTech
export_pkcs(): Use '-f' for file existence
272200f 
Signed-off-by: Richard T Bonhomme <tincantech@protonmail.com>
@TinCanTech
verify_cert(): Use '-f' for file existence
54866a1 
Signed-off-by: Richard T Bonhomme <tincantech@protonmail.com>
@TinCanTech
show() and show_ca(): Use '-f' for file existence
45b42fd 
Signed-off-by: Richard T Bonhomme <tincantech@protonmail.com>
@TinCanTech
select_vars() and source_vars(): Use '-f' for file existence
d9c9312 
Signed-off-by: Richard T Bonhomme <tincantech@protonmail.com>
@TinCanTech
Command parser: Use '-f' for file existence
12aadda 
Signed-off-by: Richard T Bonhomme <tincantech@protonmail.com>
@TinCanTech
easyrsa_mktemp(): Use '-f' for file existence
4ad4cef 
Signed-off-by: Richard T Bonhomme <tincantech@protonmail.com>
@TinCanTech
cleanup(): Add comment to explain use of '-e' for object existence
7a0839b 
Signed-off-by: Richard T Bonhomme <tincantech@protonmail.com>
@TinCanTech
init_pki(): Use '-d' for directory existence; sign_req(): Use '-f'
a2d57f5 
Signed-off-by: Richard T Bonhomme <tincantech@protonmail.com>
@TinCanTech
easyrsa-tools.lib: Use '-f' for file existence
a02f545 
Signed-off-by: Richard T Bonhomme <tincantech@protonmail.com>
@TinCanTech
ChangeLog: Switch to '-f' for file existence
2190110 
Signed-off-by: Richard T Bonhomme <tincantech@protonmail.com>
@TinCanTech TinCanTech merged commit 615ac14 into OpenVPN:master Aug 6, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@TinCanTech TinCanTech

Labels
BUG-FIX ChangeLog Item improvement Version 3.2.1-Release
Projects
None yet
Milestone
v3.2.1
Development

Successfully merging this pull request may close these issues.

Switch to -f for file existence and simplify use of easyrsa_mkdir sign-req does not build an inline file
1 participant
@TinCanTech