Make vars file more sane #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Removed duplicate KEY_EMAIL var * Commented out KEY_PCS11 vars [1] * Commented out KEY_CN with explanation * Set saner defaults * reorganized vars, "required" fields first [1] I commented these out because they're already set to dummy and you only need to change them if you're indeed going to use them. This makes it a little less confusing to newbies who may not be interested in PKCS11 and get confused when reading that they should now "leave any of these fields blank".
ghost
assigned 
|
I have pushed this to master. Thanks for the patch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[1] I commented these out because they're already set to dummy and you only need to change them if you're indeed going to use them. This makes it a little less confusing to newbies who may not be interested in PKCS11 and get confused when reading that they should now "leave any of these fields blank".