Allow --fix-offset to create post-dated certificates #804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, --fix-offset does not allow creating post-dated cerificates. Instead, it rolls the start date back by one year. The reason for this behavior is that --fix-offest was only meant to fix a day of the year but not which year. This patch simply removes the check for a post-dated certificate, which allows `not-before-date` to be set upto one year in the future. Signed-off-by: Richard T Bonhomme <tincantech@protonmail.com>
This was referenced Dec 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, --fix-offset does not allow creating post-dated cerificates. Instead, it rolls the start date back by one year.
The reason for this behavior is that --fix-offest was only meant to fix a day of the year but not which year.
This patch simply removes the check for a post-dated certificate, which allows
not-before-dateto be set upto one year in the future.Signed-off-by: Richard T Bonhomme tincantech@protonmail.com