-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows, build-ca: Add input password to re-open private key #813
Conversation
Manually tested LibreSSL:
|
Unit-test in development: |
Using OpenSSL 3.0.7, packaged by OpenVPN Windows installer, causes EasyRSA command 'build-ca' to fail, because it does not have an input password to re-open the private key, which is required to generate the CA certificate. Provide the user specified CA passphrase as input password for build-ca. Signed-off-by: Richard T Bonhomme <tincantech@protonmail.com>
059a2a7
to
8ae6bca
Compare
If 'easyrsa' is being run by the unit-test then allow the default method for 'build-ca' to be exercised. The default 'easyrsa' method is to use temp-files, generated by EasyRSA, to pass the CA passphrase, provided by the user, to the SSL command. The normal 'unit-test' method to use a passphrase is to configure EasyRSA ommand line options '--passin' and '--passout'. The change made here is to simulate user-interaction and to supply a default passphrase, as a user, to the SSL command. To NOT use EasyRSA command line options to set any passphrase. ONLY when being run by the unit-test. Signed-off-by: Richard T Bonhomme <tincantech@protonmail.com>
Force push to correct commit message. Re-committed unit-test related change |
The final part of this jigsaw puzzle is to enable the check in the unit-test.. |
What an Linux failed due to Windows failed ..... same error. Not enough input passphrases ............ |
Signed-off-by: Richard T Bonhomme <tincantech@protonmail.com>
Summary: Bug-fix: OpenSSL 3.0.7 requires the input password of the private key to build the CA certificate. Enhancement: Add unit-test for this specific code. Manually verified the unit-test log that the test is exercised. |
Also, prototype easyrsa_mktemp() errors. Signed-off-by: Richard T Bonhomme <tincantech@protonmail.com>
Using OpenSSL 3.0.7, packaged by OpenVPN Windows installer, causes EasyRSA command 'build-ca' to fail, because it does not have an input password to re-open the private key, which is required to generate the CA certificate or subCA request file.
Provide the user specified CA passphrase as input password for build-ca.
Signed-off-by: Richard T Bonhomme tincantech@protonmail.com