SOCKS proxy 5 second handshake/auth/connect hard-coded timeout

[ValdikSS]

Describe the bug
OpenVPN 2.5, 2.6 and master have a hard-coded timeout of 5 seconds for SOCKS communications, which may not be enough for slow proxies, such as when the connection is performed over Tor.

To Reproduce

1. Setup OpenVPN server using TCP
2. Configure Tor Hidden Service to that server
3. On another machine, configure client to Tor hidden service VPN using Tor's SOCKS port socks-proxy 127.0.0.1 9050

Expected behavior
Proxy timeout follow --server-poll-timeout value

--server-poll-timeout n
When connecting to a remote server do not wait for more than n seconds for a response before trying the next server. The de‐fault value is 120s. This timeout includes proxy and TCP connect timeouts.

Actual behavior
Socks code has a 5 second hard-coded timeout in numerous places

openvpn/src/openvpn/socks.c

Line 95 in 9c52e0c

const int timeout_sec = 5;

openvpn/src/openvpn/socks.c

Line 194 in 9c52e0c

const int timeout_sec = 5;

openvpn/src/openvpn/socks.c

Line 312 in 9c52e0c

const int timeout_sec = 5;

[5andr0]

I submitted a patch for that: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg26962.html
5andr0@e6d7add

[ValdikSS]

I can confirm that the patch works great.