add token role to participant event (CDR and webhook) #723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CSantosM
force-pushed
the
master
branch
2 times, most recently
from
7fe1145 to
d3a755b
Compare
|
Thanks for your suggestion && PR @mihailj 😄 . @pabloFuente . What do you think of this? We support in OpenVidu PRO/ENTERPRISE an API to change the role of a connection. I am not sure how consistent it is to add this to the webhook event. |
Good point about that! It will probably also need a new |
CSantosM
force-pushed
the
master
branch
10 times, most recently
from
e9de7f5 to
7d88c1f
Compare
CSantosM
force-pushed
the
master
branch
2 times, most recently
from
670697a to
6ab6c22
Compare
CSantosM
force-pushed
the
master
branch
3 times, most recently
from
bc3613c to
86d1260
Compare
CSantosM
force-pushed
the
master
branch
2 times, most recently
from
4df7846 to
5349177
Compare
CSantosM
force-pushed
the
master
branch
3 times, most recently
from
5847916 to
0cff58e
Compare
CSantosM
force-pushed
the
master
branch
10 times, most recently
from
bfa4d17 to
33d1192
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I've found extremely useful to have the participant role information in the
participantJoinedevent.Since it's a 'one-liner' (well technically 3 lines including the webhook integration test) I don't think that it needs more explanations. 😄
Regards,
Mihail