-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FFmpeg MCM audio plugin #179
Merged
ko80
merged 5 commits into
OpenVisualCloud:main
from
ko80:dev/add-mcm-ffmpeg-audio-plugin
Aug 29, 2024
Merged
Add FFmpeg MCM audio plugin #179
ko80
merged 5 commits into
OpenVisualCloud:main
from
ko80:dev/add-mcm-ffmpeg-audio-plugin
Aug 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a basic implementation of an FFmpeg MCM audio plugin to support input and output audio streaming through MCM. Signed-off-by: Konstantin Ilichev <konstantin.ilichev@intel.com>
* Added a patch for FFmpeg to support MCM. * Added a function to parse common MCM connection parameters in video and audio plugins. * Reordeded parameter definitions. * Renamed functions and structures related to the video plugin. * Improved error messages. * Added license information. Signed-off-by: Konstantin Ilichev <konstantin.ilichev@intel.com>
This commit adds the next arguments to the MCM FFmpeg plugin: * Number of audio channels (1, 2, etc.) * Sample rate (44.1, 48, or 96 kHz) * MTL PCM format (16-bit or 24-bit Big Endian) * MTL packet time To enable support of PCM 16-bit transmission, the mcm_audio_pcm16 output device has been added to implementation. The patch for the FFmpeg distribution is updated accordingly. Some refactoring is done to improve logging and argument ordering. Signed-off-by: Konstantin Ilichev <konstantin.ilichev@intel.com>
This commit adds description of how to configure and run an audio transmission via MCM FFmpeg plugin. Argument lists are provided for MCM connection, video, and audio configurations. Signed-off-by: Konstantin Ilichev <konstantin.ilichev@intel.com>
ko80
force-pushed
the
dev/add-mcm-ffmpeg-audio-plugin
branch
from
August 27, 2024 23:14
d59611a
to
c0b89d2
Compare
tszumski
approved these changes
Aug 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This commit fixes example command lines for running audio streams and adds some quotes where missed. Signed-off-by: Konstantin Ilichev <konstantin.ilichev@intel.com>
Mionsz
approved these changes
Aug 29, 2024
MateuszGrabuszynski
approved these changes
Aug 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Tested with ST30 - PCM16 audio (pcm_s16le
), 2 channels, 1ms ptime - works fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the commits listed below