Fix RDMA support in sample apps #241
Conversation
ko80
force-pushed
the
fix-rdma-sample-apps
branch
from
9b4bb04
to
c0b6bb6
Compare
Commit a4f5e3d ("Refactor MCM Data Plane SDK API + upgrade FFmpeg plugins and sample apps (OpenVisualCloud#213)") introduced a new MCM SDK API but occassionally removed RDMA support from sample apps. Add support of RDMA in sample apps with the new API. Fixes: a4f5e3d ("Refactor MCM Data Plane SDK API + upgrade FFmpeg plugins and sample apps (OpenVisualCloud#213)") Signed-off-by: Konstantin Ilichev <konstantin.ilichev@intel.com> Change-type: DefectResolution
ko80
force-pushed
the
fix-rdma-sample-apps
branch
from
c0b6bb6
to
dffddf8
Compare
Signed-off-by: Kasiewicz, Marek <marek.kasiewicz@intel.com>
There was a problem hiding this comment.
I see some imperfections in the design as we are forced to create a big if statement to switch between payload types and set exactly the same fields (ip and ports) in almost identical structures.
I guess it should be done differently for example with some inheritance ( translated into C: placing common structure at the front of the specific structure) then we could set common parameters ones, and branch only to do things that are different.
Anyway, the code works. The design improvements can be done in the future.
Yeah, it will be reworked shortly since we've already planned to move to the JSON-based configuration. |
This pull request includes the following commits: