Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for new ST2110-41 (Fast Metadata Framework, "fmd") standard. #951

Merged
merged 11 commits into from
Sep 9, 2024
Merged

Add support for new ST2110-41 (Fast Metadata Framework, "fmd") standard. #951

merged 11 commits into from
Sep 9, 2024

Conversation

skolelis
Copy link
Collaborator

@skolelis skolelis commented Aug 22, 2024 •
edited
Loading

Add support for new ST2110-41 (Fast Metadata Framework) standard.

Add support for new ST2110-41 (Fast Metadata Framework, "fmd") standard.
As abbreviation in the code "fmd".

Support for st41 in /include/ directory.
Support for st41 in RxTxApp.
with added options in JSON file in RxTxApp (for RX and TX):
"fastmetadata": [
with options for TX:
"fastmetadata_data_item_type": 3648364,
"fastmetadata_k_bit": 1,
"fastmetadata_url": "test_abc.txt",
"fastmetadata_fps": "p59"

@skolelis skolelis marked this pull request as draft August 22, 2024 11:08
@skolelis skolelis marked this pull request as ready for review September 6, 2024 12:50
@skolelis skolelis changed the title added the second instance of st40 with the name of st41 Add support for new ST2110-41 (Fast Metadata Framework, "fmd") standard. Sep 6, 2024
@DawidWesierski4
Copy link
Collaborator

Any logs from RX TX app as proof of working ?

@skolelis
Copy link
Collaborator Author

skolelis commented Sep 6, 2024

Running test: ===========================================
./build/tests/KahawaiUfdTest --p_port 0000:31:01.0 --r_port 0000:31:01.1

Test passed in 17 seconds.

===========================================
Running test: ===========================================
./build/tests/KahawaiUfdTest --p_port 0000:31:01.0 --r_port 0000:31:01.1 --queue_mode shared

Test passed in 19 seconds.

===========================================
Running test: ===========================================
./build/tests/KahawaiUfdTest --p_port 0000:31:01.0 --r_port 0000:31:01.1 --queue_mode shared --udp_lcore

Test passed in 19 seconds.

===========================================
Running test: ===========================================
./build/tests/KahawaiUfdTest --p_port 0000:31:01.0 --r_port 0000:31:01.1 --rss_mode l3_l4

Test passed in 21 seconds.

===========================================
Running test: ===========================================
./build/tests/KahawaiTest --auto_start_stop --p_port 0000:31:01.0 --r_port 0000:31:01.1 --dma_dev 0000:00:01.0,0000:00:01.1 --gtest_filter=-St22_?x.*

Test passed in 780 seconds.

===========================================
Running test: ===========================================
./build/tests/KahawaiTest --auto_start_stop --p_port 0000:31:01.0 --r_port 0000:31:01.1 --rss_mode l3_l4 --pacing_way tsc --iova_mode pa --multi_src_port --gtest_filter=Main.:St20p:-ext

Test passed in 82 seconds.

===========================================
Running test: ===========================================
./build/tests/KahawaiTest --p_port kernel:lo --r_port kernel:lo --auto_start_stop --gtest_filter=St20p*

Test passed in 139 seconds.

===========================================

@skolelis
Copy link
Collaborator Author

skolelis commented Sep 6, 2024

Any logs from RX TX app as proof of working ?

I checked manually the function: app_rx_fmd_read_thread() -> and rebuilt app_rx_fmd_handle_rtp()
and I see the payload is arriving there (for both "frame" and "rtp" modes).

The function app_rx_fmd_handle_rtp() is to be extended with tests for RX as next step.

DawidWesierski4
DawidWesierski4 reviewed Sep 9, 2024
View reviewed changes
Copy link
Collaborator

@DawidWesierski4 DawidWesierski4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally just small things nothign major
i don't see glaring guns

if you can add the header guards and the proper year / addnotation to the new files we should be fine

app/src/app_base.h Show resolved Hide resolved
app/src/rx_fastmetadata_app.c Outdated Show resolved Hide resolved
app/src/rx_fastmetadata_app.h Outdated Show resolved Hide resolved
app/src/tx_fastmetadata_app.c Outdated Show resolved Hide resolved
app/src/tx_fastmetadata_app.h Outdated Show resolved Hide resolved
lib/src/st2110/st_rx_fastmetadata_session.h Outdated Show resolved Hide resolved
lib/src/st2110/st_rx_fastmetadata_session.c Outdated Show resolved Hide resolved
lib/src/st2110/st_tx_fastmetadata_session.c Outdated Show resolved Hide resolved
lib/src/st2110/st_tx_fastmetadata_session.h Outdated Show resolved Hide resolved
lib/src/st2110/st_tx_fastmetadata_session.h Outdated Show resolved Hide resolved
@DawidWesierski4
Copy link
Collaborator

Please rebase to the newest branch to include CI fixes if you can

soopel
soopel approved these changes Sep 9, 2024
View reviewed changes
Copy link

@soopel soopel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@skolelis
Added the second instance of st40 with the name of st41 (as copy of s…
fc94892 
…t40). Both are functional and work according to st40 standard independently.

The substitutes are:
st40 -> st41,
st2110-40 -> st2110-41,
ancillary -> fast metadata (in comments, descriptions etc.),
ancillary -> fastmetadata (in names of functions / variables, constants, files etc.),
anc -> fmd,
(with small and capital letters accordingly.)
@skolelis
rebuild copy of st40 called st41 to have the network frames according…
2d1d73e 
… to the standard document about st2110-41

compiling. not tested at all
@skolelis
st41 working for frame and rtp modes
097d1dc
@skolelis
making order with whitespaces
92a3c70
@skolelis
removed not needed (empty laready file st_fastmetadata.c
2235cfc
@skolelis
removing private comments, cleanup of some structure fields names
7020fe5
@skolelis
removal of few more private comments (in FMD RX and in headers)
f819e8f
@skolelis
apply format coding
cb2496f
@skolelis
copyright headers fixed + comments of #endif's in header files
ac16f88
@soopel soopel merged commit c43152d into main Sep 9, 2024
27 of 33 checks passed
@soopel soopel deleted the st41_draft_01 branch September 9, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DawidWesierski4 DawidWesierski4 DawidWesierski4 left review comments

@soopel soopel soopel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@skolelis @DawidWesierski4 @soopel