This repository has been archived by the owner on Jul 29, 2024. It is now read-only.
Unpack fixes #476
Closed
Unpack fixes #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some changes to make unpack process more consistent with other processes 1) Changed cast of unpackContexPtr from EB_PTR to EB_PTR* to match encHandlePtr->unpackContextPtr definition 2) EB_ENC_UnPack2D_TYPE identify is used for two different purposes - structure for parameters and for function type. Renamed definition in EbPackUnPack.h to EB_ENC_UnPack2D_FUNC_TYPE 3) Change UnPack2D function parameter to void* and cast to UnPackContext_t* in EbGetFullObject and EbGetEmptyObject calls Signed-off-by: Mark Feldman <mark.feldman@intel.com>
|
Hi Mark, some of your changes are included in my PR #467. Could you review those changes relevant to this PR? Thank you. |
|
@Tian, Jun<mailto:jun.tian@intel.com> - Thanks for the heads up . There is some overlap – I’ll wait for your PR to get approved and re-evaluate these changes.
From: Jun <notifications@github.com>
Sent: Friday, February 14, 2020 10:51 AM
To: OpenVisualCloud/SVT-HEVC <SVT-HEVC@noreply.github.com>
Cc: Feldman, Mark <mark.feldman@intel.com>; Author <author@noreply.github.com>
Subject: Re: [OpenVisualCloud/SVT-HEVC] Unpack fixes (#476)
Hi Mark, some of your changes are included in my PR #467<#467>. Could you review those changes relevant to this PR? Thank you.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#476?email_source=notifications&email_token=AMC5UQQEJZ75QN4EPNYTQWDRC3KZ7A5CNFSM4KVMYPC2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELZ3P4Y#issuecomment-586397683>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AMC5UQS74U2FC437ZIE3Y4TRC3KZ7ANCNFSM4KVMYPCQ>.
|
|
Hi @intelmark , Mark, you could continue this PR now:) Thank you. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some changes to make unpack process more consistent
with other processes
Changed cast of unpackContexPtr from EB_PTR to EB_PTR* to match
encHandlePtr->unpackContextPtr definition
EB_ENC_UnPack2D_TYPE identify is used for two different purposes -
structure for parameters and for function type. Renamed
definition in EbPackUnPack.h to EB_ENC_UnPack2D_FUNC_TYPE
Change UnPack2D function parameter to void* and cast to
UnPackContext_t* in EbGetFullObject and EbGetEmptyObject calls
Signed-off-by: Mark Feldman mark.feldman@intel.com