Skip to content
This repository has been archived by the owner on Jul 29, 2024. It is now read-only.

Worked around the random encoding hang issue due to incorrect number #512

Closed

Conversation

Austin-Hu
Copy link
Contributor

@Austin-Hu Austin-Hu commented Apr 1, 2020

of FIFO objects.

Signed-off-by: Austin Hu austin.hu@intel.com

As the 3rd (work around) option, to fix #497 , #514 .

of FIFO objects.

Signed-off-by: Austin Hu <austin.hu@intel.com>
sequenceControlSetPtr->inputOutputBufferFifoInitCount = inputPic + SCD_LAD;
sequenceControlSetPtr->inputOutputBufferFifoInitCount = inputPic + SCD_LAD +
sequenceControlSetPtr->staticConfig.lookAheadDistance +
sequenceControlSetPtr->staticConfig.intraPeriodLength;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is lookAheadDistance alone good enough?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, either lookAheadDistance or intraPeriodLength alone isn't good enough...

@tianjunwork tianjunwork added the bug Something isn't working label Apr 1, 2020
@Austin-Hu
Copy link
Contributor Author

With the PR applied, encoding performance could be increased. But memory consumption would be increased as its side effect, due to the increased number of Output FIFO objects, which take memory calculated by: EB_OUTPUTSTREAMBUFFERSIZE_MACRO * number_of_output_fifo, where EB_OUTPUTSTREAMBUFFERSIZE_MACRO depends on input resolution.

Some typical encoding performance and memory consumption comparison:

Command Data Type Without PR #512 With PR #512
./SvtHevcEncApp -i bbb_1920x1080_420p.yuv -w 1920 -h 1080 -n 5000 -b 0.265 Encoding Performance (FPS) 160 327
Memory (GB) 2 2.4
./SvtHevcEncApp -i bbb_1920x1080_420p.yuv -w 1920 -h 1080 -encMode 0 -intra-period 100 -scd 0 -rc 0 -q 22 -n 1000 -b 0.265 Encoding Performance (FPS) 3.73 6.9
Memory (GB) 2.2 2.5
./SvtHevcEncApp -i 7680x3840_P444.yuv -w 7680 -h 3840 -color-format 3 -b 0.265 -n 500 Encoding Performance (FPS) 16.56 18.25
Memory (GB) 26.5 26.9

@tianjunwork
Copy link
Contributor

Hi @Austin-Hu , I will re-enable out_alloc and increase stream output fifo to fix the hang issue. will close this one. Thank you for doing the profiling.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Encoder random hang
2 participants