Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

load either user or admin #24

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

emphasize
Copy link
Member

@emphasize emphasize commented Sep 19, 2023

Prerequisite to be able to setup plugins both as admin and user.

i.e.

entry_points={'ovos.plugin.phal': PLUGIN_ENTRY_POINT,
              'ovos.plugin.phal.admin': PLUGIN_ENTRY_POINT}

During load time the one that isn't defined in the specific "section" of the PHAL configuration gets dropped

{
    "PHAL": {
        "admin": {
             "ovos-PHAL-plugin-system": {"enabled": true, ... }
        }
    }
}

only admin plugin gets loaded

{
    "PHAL": {
        "ovos-PHAL-plugin-system": {"enabled": true, ... }
     }
}

only user plugin gets loaded

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (00ad25f) 0.00% compared to head (b408aa6) 0.00%.
Report is 1 commits behind head on dev.

Additional details and impacted files
@@          Coverage Diff          @@
##             dev     #24   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files          6       6           
  Lines        158     163    +5     
=====================================
- Misses       158     163    +5     
Files Changed Coverage Δ
ovos_PHAL/admin.py 0.00% <0.00%> (ø)
ovos_PHAL/service.py 0.00% <0.00%> (ø)
ovos_PHAL/version.py 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JarbasAl JarbasAl added the enhancement New feature or request label Sep 19, 2023
@JarbasAl JarbasAl merged commit bca9eaa into OpenVoiceOS:dev Sep 19, 2023
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants