Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/skip_skills_in_dialog_transform #30

Merged
merged 2 commits into from
Oct 9, 2023

Conversation

JarbasAl
Copy link
Member

@JarbasAl JarbasAl commented Oct 9, 2023

allow some skills to explicitly skip the dialog transformers

by default jokes skill is blacklisted

"dialog_transformers": {
    "blacklisted_skills": ["skill-ovos-icanhazdadjokes.openvoiceos"]
}

allow some skills to explicitly skip the dialog transformers

by default jokes skill is blacklisted

```
"dialog_transformers": {
    "blacklisted_skills": ["skill-ovos-icanhazdadjokes.openvoiceos"]
}
```
@JarbasAl JarbasAl added the enhancement New feature or request label Oct 9, 2023
@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

All modified lines are covered by tests ✅

❗ No coverage uploaded for pull request base (dev@fe869e3). Click here to learn what that means.

Additional details and impacted files
@@          Coverage Diff          @@
##             dev     #30   +/-   ##
=====================================
  Coverage       ?   0.00%           
=====================================
  Files          ?       8           
  Lines          ?     914           
  Branches       ?       0           
=====================================
  Hits           ?       0           
  Misses         ?     914           
  Partials       ?       0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JarbasAl JarbasAl merged commit 84d510e into dev Oct 9, 2023
5 checks passed
@JarbasAl JarbasAl deleted the feat/skip_skills_in_dialog_transform branch October 9, 2023 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant